You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/01/07 13:19:27 UTC

[GitHub] [maven] KroArtem commented on a change in pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions

KroArtem commented on a change in pull request #312: [MNG-6844] replace string-defined charsets by StandardCharsets and remove unneeded suppressions
URL: https://github.com/apache/maven/pull/312#discussion_r363743171
 
 

 ##########
 File path: maven-compat/src/test/java/org/apache/maven/repository/legacy/StringWagon.java
 ##########
 @@ -72,14 +73,7 @@ public void fillInputData( InputData inputData )
             resource.setContentLength( content.length() );
             resource.setLastModified( System.currentTimeMillis() );
 
-            try
-            {
-                inputData.setInputStream( new ByteArrayInputStream( content.getBytes( "UTF-8" ) ) );
-            }
-            catch ( UnsupportedEncodingException e )
-            {
-                throw new Error( "broken JVM", e );
-            }
+            inputData.setInputStream( new ByteArrayInputStream( content.getBytes(StandardCharsets.UTF_8) ) );
 
 Review comment:
   That's strange, I've fixed it after running `clean verify`
   
   Will fix a bit later

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services