[GitHub] reminisce commented on a change in pull request #7082: Sparse Tensor: request for reviews

[gi...@git.apache.org]

reminisce commented on a change in pull request #7082: Sparse Tensor: request for reviews
URL: https://github.com/apache/incubator-mxnet/pull/7082#discussion_r133617599
 
 

 ##########
 File path: include/mxnet/c_api.h
 ##########
 @@ -321,6 +353,17 @@ MXNET_DLL int MXNDArraySyncCopyToCPU(NDArrayHandle handle,
                                      void *data,
                                      size_t size);
 /*!
+ * \brief Copy src.data() to dst.data() if i = -1, else dst.aux_data(i) if i >= 0
+ * This function blocks. Do not use it in performance critical code.
+ * \param handle_dst handle of a dst ndarray whose data/aux_data has been allocated
+ * \param handle_src handle of a src ndarray which has default storage type
+ * \param i dst data blob indicator
+ */
+MXNET_DLL int MXNDArraySyncCopyFromNDArray(NDArrayHandle handle_dst,
+                                           const NDArrayHandle handle_src,
+                                           const int i);
 
 Review comment:
   Agree with @eric-haibin-lin. As long as it's documented clearly in the comment, it's fine to use `i`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services