You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "celeste-zeng (via GitHub)" <gi...@apache.org> on 2024/05/30 04:17:04 UTC
[PR] Plumb Redistribute Transform's AllowDuplicates Property to Job Definition [beam]
celeste-zeng opened a new pull request, #31450:
URL: https://github.com/apache/beam/pull/31450
In enterCompositeTransform, if a transform has its own specialized translator, translate the transform in the method.
Added a special translator for Redistribute.RedistributeArbitrarily.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Plumb Redistribute Transform's AllowDuplicates Property to Job Definition [beam]
Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #31450:
URL: https://github.com/apache/beam/pull/31450#issuecomment-2138651030
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Plumb Redistribute Transform's AllowDuplicates Property to Job Definition [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #31450:
URL: https://github.com/apache/beam/pull/31450#discussion_r1621070528
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java:
##########
@@ -592,6 +593,14 @@ public CompositeBehavior enterCompositeTransform(TransformHierarchy.Node node) {
if (!node.isRootNode()) {
parents.addFirst(node);
}
+ PTransform<?, ?> transform = node.getTransform();
+ if (transform != null) {
Review Comment:
Oh wait yea I guess the root node can be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Plumb Redistribute Transform's AllowDuplicates Property to Job Definition [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31450:
URL: https://github.com/apache/beam/pull/31450#issuecomment-2138652096
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Plumb Redistribute Transform's AllowDuplicates Property to Job Definition [beam]
Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng closed pull request #31450: Plumb Redistribute Transform's AllowDuplicates Property to Job Definition
URL: https://github.com/apache/beam/pull/31450
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Plumb Redistribute Transform's AllowDuplicates Property to Job Definition [beam]
Posted by "celeste-zeng (via GitHub)" <gi...@apache.org>.
celeste-zeng commented on PR #31450:
URL: https://github.com/apache/beam/pull/31450#issuecomment-2151386535
This approach won't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Plumb Redistribute Transform's AllowDuplicates Property to Job Definition [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on code in PR #31450:
URL: https://github.com/apache/beam/pull/31450#discussion_r1621053411
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java:
##########
@@ -592,6 +593,14 @@ public CompositeBehavior enterCompositeTransform(TransformHierarchy.Node node) {
if (!node.isRootNode()) {
parents.addFirst(node);
}
+ PTransform<?, ?> transform = node.getTransform();
+ if (transform != null) {
Review Comment:
I don't think this can be null.
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java:
##########
@@ -954,6 +963,41 @@ private <K, V> void redistributeByKeyHelper(
}
});
+ registerTransformTranslator(
+ RedistributeArbitrarily.class,
+ new TransformTranslator<RedistributeArbitrarily>() {
+ @Override
+ public void translate(RedistributeArbitrarily transform, TranslationContext context) {
+ redistributeArbitrarilyHelper(transform, context);
+ }
+
+ private <T> void redistributeArbitrarilyHelper(
+ RedistributeArbitrarily<T> transform, TranslationContext context) {
+ StepTranslationContext stepContext = context.addStep(transform, "GroupByKey");
Review Comment:
This is a problem because the input is not necessarily keyed. I think the change you made above should make the RedistributeByKey translator suffice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org