You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/30 02:33:21 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1311: libc: Move double_t typedef from sys/types.h to math.h

xiaoxiang781216 commented on a change in pull request #1311:
URL: https://github.com/apache/incubator-nuttx/pull/1311#discussion_r447371922



##########
File path: include/sys/types.h
##########
@@ -104,17 +105,6 @@
 
 #ifndef __ASSEMBLY__
 
-/* Floating point types */

Review comment:
       You don't need define CONFIG_LIBM to get these types, because math.h from the 3rd party will provide the similar typedef for you(e.g. newlib):
   https://github.com/bminor/newlib/blob/master/newlib/libc/include/math.h#L151
   Instead this patch avoid that NuttX typedef in sys/types.h is different from math.h in the 3rd party code which is important to keep the binary compatibility because all source code in NuttX use the same double_t/float_t typedef as 3rd party library.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org