[GitHub] [spark] ulysses-you commented on a diff in pull request #41979: [SPARK-43952][SQL][FOLLOWUP] Correct AQE cancel broadcast job tag

["ulysses-you (via GitHub)" <gi...@apache.org>]

ulysses-you commented on code in PR #41979:
URL: https://github.com/apache/spark/pull/41979#discussion_r1262058936


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala:
##########
@@ -45,9 +45,16 @@ import org.apache.spark.util.{SparkFatalException, ThreadUtils}
 trait BroadcastExchangeLike extends Exchange {
 
   /**
-   * The broadcast job group ID
+   * The broadcast run ID in job tag
    */
-  def runId: UUID = UUID.randomUUID
+  @deprecated("Use jobTag", "3.5.0")

Review Comment:
   The reason is that, the semantics of runId lightly changed. Before it represents the job id, and now it is the unique id in job tag. But I'm fine to remove it if you think it is unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org