[GitHub] [incubator-pinot] jackjlli commented on pull request #6640: Make Pinot metrics pluggable

[GitBox <gi...@apache.org>]

jackjlli commented on pull request #6640:
URL: https://github.com/apache/incubator-pinot/pull/6640#issuecomment-790198656


   > Also, add the backward-incompatible tag and mention that for users who override the `plugins.include` env variable, they need to add `pinot-yammer` to it in order to get metrics reported.
   > 
   > Or we can try to look for `pinot-yammer` in PluginManager init() method if no metrics plugin is specified, then it should be backward compatible.
   > 
   
   For now I put pinot-yammer under pinot-common.
   
   > Also, add the backward-incompatible tag and mention that for users who override the `plugins.include` env variable, they need to add `pinot-yammer` to it in order to get metrics reported.
   > 
   > Or we can try to look for `pinot-yammer` in PluginManager init() method if no metrics plugin is specified, then it should be backward compatible.
   
   PR descriptions updated and pinot-assembly.xml adjusted. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org