[GitHub] [yetus] elek commented on a change in pull request #46: YETUS-816. Improve hadoop personality to support ozone/hdds projects

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #46: YETUS-816. Improve hadoop personality to support ozone/hdds projects
URL: https://github.com/apache/yetus/pull/46#discussion_r263396139
 
 

 ##########
 File path: precommit/src/main/shell/personality/hadoop.sh
 ##########
 @@ -404,11 +404,34 @@ function personality_modules
   fi
 
   extra="-Ptest-patch ${extra}"
-
-  for module in $(hadoop_order ${ordering}); do
-    # shellcheck disable=SC2086
-    personality_enqueue_module ${module} ${extra}
+  OZONE_CHANGED=false
+  CORE_HADOOP_CHANGED=false
+  for module in $CHANGED_MODULES
 
 Review comment:
   Thanks a lot, fixed. 
   
   
   (BTW, It was not flagged, I don't know why: 
   
   ```
   precommit/src/main/shell/personality/hadoop.sh:426:46: note: Double quote to prevent globbing and word splitting. [SC2086]
   precommit/src/main/shell/personality/hadoop.sh:427:47: note: Double quote to prevent globbing and word splitting. [SC2086]
   ```
   
   I tested with a simple shell script and similar structure was flagged there. I think the type of the CHANGED_MODULES is unknown here...)
   
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services