You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/05/06 19:26:25 UTC
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24279
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
IMPALA-14951: Fix hang during Iceberg delete with tuple cache
With mt_dop, IcebergDeleteNode has the same independent
builder as PartitionedHashJoinNode. It needs the same logic
used for IMPALA-13660 to notify the build side when a probe
side thread closes before probing. Interestingly enough,
this is hard to demonstrate with a select. The coordinator
cancels the query when it receives all the rows, which posts
the builder out of its wait. However, for a delete, this is
not true, so it can hang indefinitely.
This centralizes the necessary logic to share it between
PartitionedHashJoinNode, NestedLoopJoinNode, and
IcebergDeleteNode. Applying it to IcebergDeleteNode fixes
the hang.
Testing:
- Added a test case that consistently reproduced the hang
before the fix
Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
---
M be/src/exec/blocking-join-node.h
M be/src/exec/iceberg-delete-node.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-node.cc
A testdata/workloads/functional-query/queries/QueryTest/tuple-cache-iceberg-v2-deletes.test
M tests/custom_cluster/test_tuple_cache.py
6 files changed, 370 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/24279/1
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 13 May 2026 02:47:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13424/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2026 20:28:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13460/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 22:25:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24279
to look at the new patch set (#2).
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
IMPALA-14951: Fix hang during Iceberg delete with tuple cache
With mt_dop, IcebergDeleteNode has the same independent
builder as PartitionedHashJoinNode. It needs the same logic
used for IMPALA-13660 to notify the build side when a probe
side thread closes before probing. Interestingly enough,
this is hard to demonstrate with a select. The coordinator
cancels the query when it receives all the rows, which posts
the builder out of its wait. However, for a delete, this is
not true, so it can hang indefinitely.
This centralizes the necessary logic to share it between
PartitionedHashJoinNode, NestedLoopJoinNode, and
IcebergDeleteNode. Applying it to IcebergDeleteNode fixes
the hang.
Testing:
- Added a test case that consistently reproduced the hang
before the fix
Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
---
M be/src/exec/blocking-join-node.h
M be/src/exec/iceberg-delete-node.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-node.cc
A testdata/workloads/functional-query/queries/QueryTest/tuple-cache-iceberg-v2-deletes.test
M tests/custom_cluster/test_tuple_cache.py
6 files changed, 371 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/24279/2
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13429/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 19:58:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/blocking-join-node.h
File be/src/exec/blocking-join-node.h:
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/blocking-join-node.h@272
PS4, Line 272: RuntimeState* state, T** builder
> Minor thing, adding a couple of DCHECKs seem safer as a separate function.
Done
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 22:18:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22340/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2026 20:18:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
IMPALA-14951: Fix hang during Iceberg delete with tuple cache
With mt_dop, IcebergDeleteNode has the same independent
builder as PartitionedHashJoinNode. It needs the same logic
used for IMPALA-13660 to notify the build side when a probe
side thread closes before probing. Interestingly enough,
this is hard to demonstrate with a select. The coordinator
cancels the query when it receives all the rows, which posts
the builder out of its wait. However, for a delete, this is
not true, so it can hang indefinitely.
This centralizes the necessary logic to share it between
PartitionedHashJoinNode, NestedLoopJoinNode, and
IcebergDeleteNode. Applying it to IcebergDeleteNode fixes
the hang.
Testing:
- Added a test case that consistently reproduced the hang
before the fix
Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Reviewed-on: http://gerrit.cloudera.org:8080/24279
Reviewed-by: Yida Wu <wy...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/blocking-join-node.h
M be/src/exec/iceberg-delete-node.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-node.cc
A testdata/workloads/functional-query/queries/QueryTest/tuple-cache-iceberg-v2-deletes.test
M tests/custom_cluster/test_tuple_cache.py
6 files changed, 377 insertions(+), 59 deletions(-)
Approvals:
Yida Wu: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 6
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/blocking-join-node.h
File be/src/exec/blocking-join-node.h:
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/blocking-join-node.h@272
PS4, Line 272: RuntimeState* state, T** builder
Minor thing, adding a couple of DCHECKs seem safer as a separate function.
DCHECK(state != nullptr);
DCHECK(builder != nullptr);
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 21:57:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h
File be/src/exec/blocking-join-node.h:
http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h@287
PS2, Line 287: if (separate_build && !waited_for_build_) {
> Oops! I had some back and forth during development about whether this shoul
Done
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 18:36:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24279
to look at the new patch set (#4).
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
IMPALA-14951: Fix hang during Iceberg delete with tuple cache
With mt_dop, IcebergDeleteNode has the same independent
builder as PartitionedHashJoinNode. It needs the same logic
used for IMPALA-13660 to notify the build side when a probe
side thread closes before probing. Interestingly enough,
this is hard to demonstrate with a select. The coordinator
cancels the query when it receives all the rows, which posts
the builder out of its wait. However, for a delete, this is
not true, so it can hang indefinitely.
This centralizes the necessary logic to share it between
PartitionedHashJoinNode, NestedLoopJoinNode, and
IcebergDeleteNode. Applying it to IcebergDeleteNode fixes
the hang.
Testing:
- Added a test case that consistently reproduced the hang
before the fix
Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
---
M be/src/exec/blocking-join-node.h
M be/src/exec/iceberg-delete-node.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-node.cc
A testdata/workloads/functional-query/queries/QueryTest/tuple-cache-iceberg-v2-deletes.test
M tests/custom_cluster/test_tuple_cache.py
6 files changed, 375 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/24279/4
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22339/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2026 19:48:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24279
to look at the new patch set (#5).
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
IMPALA-14951: Fix hang during Iceberg delete with tuple cache
With mt_dop, IcebergDeleteNode has the same independent
builder as PartitionedHashJoinNode. It needs the same logic
used for IMPALA-13660 to notify the build side when a probe
side thread closes before probing. Interestingly enough,
this is hard to demonstrate with a select. The coordinator
cancels the query when it receives all the rows, which posts
the builder out of its wait. However, for a delete, this is
not true, so it can hang indefinitely.
This centralizes the necessary logic to share it between
PartitionedHashJoinNode, NestedLoopJoinNode, and
IcebergDeleteNode. Applying it to IcebergDeleteNode fixes
the hang.
Testing:
- Added a test case that consistently reproduced the hang
before the fix
Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
---
M be/src/exec/blocking-join-node.h
M be/src/exec/iceberg-delete-node.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-node.cc
A testdata/workloads/functional-query/queries/QueryTest/tuple-cache-iceberg-v2-deletes.test
M tests/custom_cluster/test_tuple_cache.py
6 files changed, 377 insertions(+), 59 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/24279/5
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 22:36:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22342/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 00:24:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc@304
PS4, Line 304: DCHECK_NE(builder_, nullptr);
> Yes, that's right. waited_for_build_ can only be set to true after builder_
Ack
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 18:58:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc@304
PS4, Line 304: DCHECK_NE(builder_, nullptr);
> How do you know builder_ is not null here? Because waited_for_build_ is alw
Yes, that's right. waited_for_build_ can only be set to true after builder_ is set.
The code that looks up the builder when it is null DCHECKs that waited_for_build_ is false, so we can't have been using that path before.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 17:41:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13461/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 22:37:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4:
Ran into a test failure hitting a DCHECK in the buffer pool. I haven't been able to reproduce it locally, but I think it is related to this patch. I reordered the Close() code in PartitionedHashJoinNode to return the buffer pool reservation before calling UnregisterFromBuilder() to avoid race conditions.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 05:53:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Hello Kurt Deschler, Yida Wu, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24279
to look at the new patch set (#3).
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
IMPALA-14951: Fix hang during Iceberg delete with tuple cache
With mt_dop, IcebergDeleteNode has the same independent
builder as PartitionedHashJoinNode. It needs the same logic
used for IMPALA-13660 to notify the build side when a probe
side thread closes before probing. Interestingly enough,
this is hard to demonstrate with a select. The coordinator
cancels the query when it receives all the rows, which posts
the builder out of its wait. However, for a delete, this is
not true, so it can hang indefinitely.
This centralizes the necessary logic to share it between
PartitionedHashJoinNode, NestedLoopJoinNode, and
IcebergDeleteNode. Applying it to IcebergDeleteNode fixes
the hang.
Testing:
- Added a test case that consistently reproduced the hang
before the fix
Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
---
M be/src/exec/blocking-join-node.h
M be/src/exec/iceberg-delete-node.cc
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-node.cc
A testdata/workloads/functional-query/queries/QueryTest/tuple-cache-iceberg-v2-deletes.test
M tests/custom_cluster/test_tuple_cache.py
6 files changed, 371 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/24279/3
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 10:16:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 07 May 2026 00:54:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc
File be/src/exec/partitioned-hash-join-node.cc:
http://gerrit.cloudera.org:8080/#/c/24279/4/be/src/exec/partitioned-hash-join-node.cc@304
PS4, Line 304: DCHECK_NE(builder_, nullptr);
How do you know builder_ is not null here? Because waited_for_build_ is always set after initializing builder_
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 17:28:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24279/1/tests/custom_cluster/test_tuple_cache.py
File tests/custom_cluster/test_tuple_cache.py:
http://gerrit.cloudera.org:8080/#/c/24279/1/tests/custom_cluster/test_tuple_cache.py@719
PS1, Line 719: a
flake8: E501 line too long (98 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 May 2026 19:28:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h
File be/src/exec/blocking-join-node.h:
http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h@287
PS2, Line 287: if (UseSeparateBuild(state->query_options()) && !waited_for_build_) {
Why recalculate separate_build here? None of the prior implementations did.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 06 May 2026 23:21:39 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h
File be/src/exec/blocking-join-node.h:
http://gerrit.cloudera.org:8080/#/c/24279/2/be/src/exec/blocking-join-node.h@287
PS2, Line 287: if (UseSeparateBuild(state->query_options()) && !waited_for_build_) {
> Why recalculate separate_build here? None of the prior implementations did.
Oops! I had some back and forth during development about whether this should be one function or two. This is just a relic of when it was two functions. I'll fix it.
http://gerrit.cloudera.org:8080/#/c/24279/1/tests/custom_cluster/test_tuple_cache.py
File tests/custom_cluster/test_tuple_cache.py:
http://gerrit.cloudera.org:8080/#/c/24279/1/tests/custom_cluster/test_tuple_cache.py@719
PS1, Line 719:
> flake8: E501 line too long (98 > 90 characters)
Done
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Wed, 06 May 2026 23:54:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13433/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 05:54:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22361/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 06:15:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22398/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 5
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Tue, 12 May 2026 22:39:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14951: Fix hang during Iceberg delete with tuple cache
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24279 )
Change subject: IMPALA-14951: Fix hang during Iceberg delete with tuple cache
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13429/
--
To view, visit http://gerrit.cloudera.org:8080/24279
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff9228446f69ce43ed303c96893a91b99474800d
Gerrit-Change-Number: 24279
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 08 May 2026 00:29:15 +0000
Gerrit-HasComments: No