You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/03/28 08:51:01 UTC
[GitHub] [hive] marton-bod commented on a change in pull request #3132: HIVE-26064: For Iceberg external table do not set external.table.purge=true by default
marton-bod commented on a change in pull request #3132:
URL: https://github.com/apache/hive/pull/3132#discussion_r836194268
##########
File path: iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -1052,6 +1053,47 @@ public void testDropTableWithAppendedData() throws IOException {
shell.executeStatement("DROP TABLE customers");
}
+ @Test
+ public void testDropTableWithoutPurge() throws IOException {
+ TableIdentifier identifier = TableIdentifier.of("default", "customers");
+
+ shell.executeStatement("CREATE EXTERNAL TABLE customers (" +
+ "t_int INT, " +
+ "t_string STRING) " +
+ "STORED BY ICEBERG " +
+ testTables.locationForCreateTableSQL(identifier) +
+ testTables.propertiesForCreateTableSQL(ImmutableMap.of(InputFormatConfig.EXTERNAL_TABLE_PURGE, "FALSE")));
Review comment:
How about running this test without adding the purge=false flag explicitly? Explicitly adding it with FALSE will circumvent the MetaHook behaviour for the default case where the purge flag is simply omitted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org