[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks

[GitBox <gi...@apache.org>]

xiaohui-sun commented on a change in pull request #4217: [TE] distribute detection and notification tasks
URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285311603
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskRunner.java
 ##########
 @@ -107,13 +107,6 @@ private void updateAlertConfigWatermarks(DetectionAlertFilterResult result, Dete
       DetectionAlertFilter alertFilter = detAlertTaskFactory.loadAlertFilter(alertConfig, System.currentTimeMillis());
       DetectionAlertFilterResult result = alertFilter.run();
 
-      // TODO: The old UI relies on notified tag to display the anomalies. After the migration
-      // we need to clean up all references to notified tag.
-      for (MergedAnomalyResultDTO anomaly : result.getAllAnomalies()) {
 
 Review comment:
   Sure. reverted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org