[GitHub] [skywalking-nginx-lua] wu-sheng commented on a diff in pull request #103: improve e2e test

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #103:
URL: https://github.com/apache/skywalking-nginx-lua/pull/103#discussion_r853615066


##########
test/e2e/nginx/conf.d/nginx.conf:
##########
@@ -71,32 +70,14 @@ http {
             }
         }
 
-        location /tier2/lb {
-            default_type text/html;
-
-            rewrite_by_lua_block {
-                skywalking_tracer:start("e2e-test-with-mock-collector:upstream_ip2:port2")
-            }
-
-            proxy_pass http://127.0.0.1:8080/backend;
-
-            body_filter_by_lua_block {
-                skywalking_tracer:finish()
-            }
-
-            log_by_lua_block {
-                skywalking_tracer:prepareForReport()
-            }
-        }
         location /suffix {
-
             default_type text/html;
             content_by_lua_block {
                 ngx.say("<p>Suffix for testing only.</p>")
             }
 
             rewrite_by_lua_block {
-                skywalking_tracer:start("e2e-test-with-mock-collector:upstream_ip:port")
+                skywalking_tracer:start("172.16.238.13:9092")

Review Comment:
   Why this is changed to a real IP?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org