You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2004/12/18 23:21:38 UTC
[Bug 4044] New: make test, SPF test failing
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
Summary: make test, SPF test failing
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P5
Component: Regression Tests
AssignedTo: dev@spamassassin.apache.org
ReportedBy: sidney@sidney.com
Using svn trunk, latest Mail::SPF::Query from CPAN, running under Cywin
$ t/spf.t
1..2
# Running under perl version 5.008005 for cygwin
# Current time local: Sun Dec 19 09:49:57 2004
# Current time GMT: Sat Dec 18 20:49:57 2004
# Using Test.pm version 1.25
/usr/bin/perl -T -w ../spamassassin -C log/test_rules_copy --siteconfig
path log/localrules.tmp -p log/test_default.cf -t < data/nice/spf1
Checking helo_pass
Not found: helo_pass = SPF_HELO_PASS
not ok 1
# Failed test 1 in t/SATest.pm at line 549
Checking pass
Not found: pass = SPF_PASS
not ok 2
# Failed test 2 in t/SATest.pm at line 549 fail #2
Note comment number 7 in bug 3335 is reporting the same thing. I'm opening this
as a new bug because 3335 is an old one that was resolved for the submitter by
upgrading to a newer version of perl. That comment number 7 there is more recent
and appears to be the same as what I am seeing.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4044] [review] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
felicity@kluge.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
------- Additional Comments From felicity@kluge.net 2004-12-20 18:01 -------
FYI, the patch doesn't apply cleanly against 3.0.2.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4044] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
felicity@kluge.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Future |3.0.3
------- Additional Comments From felicity@kluge.net 2004-12-20 14:57 -------
I've verified this as well. The problem seems to be that google.com changed their SPF record...?
google.com descriptive text "v=spf1 ptr ?all"
So now the test gets a 'neutral', which isn't considered 'pass'.
Suggest we change the message to be from something under dnsbltest.spamassassin.org so we can
control the pass/fail/neutral aspect.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4044] [review] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
felicity@kluge.net changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dev@spamassassin.apache.org
AssignedTo|dev@spamassassin.apache.org |felicity@kluge.net
Summary|make test, SPF test failing |[review] make test, SPF test
| |failing
------- Additional Comments From felicity@kluge.net 2004-12-20 17:43 -------
move to review state
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are on the CC list for the bug, or are watching someone who is.
[Bug 4044] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
------- Additional Comments From felicity@kluge.net 2004-12-20 17:41 -------
Created an attachment (id=2579)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2579&action=view)
suggested patch
Replaced google.com address with dnsbltest.spamassassin.org so we can control
the SPF records. Added in fail tests as well.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4044] [review] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
------- Additional Comments From felicity@kluge.net 2004-12-21 10:28 -------
thanks sidney.
I'm +1 on it as well.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4044] [review] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
------- Additional Comments From schulz@adi.com 2004-12-21 12:09 -------
The patch works here.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4044] [review] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
------- Additional Comments From spamassassin-contrib@msquadrat.de 2004-12-21 09:29 -------
+1 we should not rely on any external ressources we don't control in our
regression tests.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4044] [review] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
------- Additional Comments From sidney@sidney.com 2004-12-21 14:38 -------
committed to 3.0.x branch rev 123015
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
[Bug 4044] [review] make test, SPF test failing
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4044
------- Additional Comments From sidney@sidney.com 2004-12-20 21:20 -------
Created an attachment (id=2581)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2581&action=view)
same patch made for 3.0.x branch
I applied the patch by hand to the 3.0.x branch and made a diff for it.
It passed all tests.
Here's my +1 for this in 3.0.x, in case we need a vote
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.