You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/06/07 18:52:30 UTC
Re: Review Request 70814: Added explicit roles to ACL of script tests
for UpdateFramework testing - WIP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70814/
-----------------------------------------------------------
(Updated June 7, 2019, 6:52 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Added explicit roles to ACL of script tests for UpdateFramework testing - WIP
Repository: mesos
Description (updated)
-------
Added explicit roles to ACL of script tests for UpdateFramework testing - WIP
Diffs
-----
src/tests/script.cpp 2e50861bf40ceeaf6a40476a742e6e82c23ba86f
Diff: https://reviews.apache.org/r/70814/diff/1/
Testing (updated)
-------
make check
NOTE: without this change it is not possible to subscribe the java example framework with a role/roles other than `*`
Thanks,
Andrei Sekretenko
Re: Review Request 70814: Replaced a set of single '*' role in
SCRIPT_TEST ACL with ANY.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70814/#review215880
-----------------------------------------------------------
Ship it!
Actually `*` is not a wildcard, so we should adjust the commit description accordingly.
- Benjamin Mahler
On June 12, 2019, 4:34 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70814/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 4:34 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch changes the roles set in the ACL used by SCRIPT_TESTs for the
> `register_frameworks` action from a single wildcard role (which is not
> treated by the local authorizer in any special way, i.e. only wildcard
> is allowed) to `ANY`. This is needed for adding and removing roles via
> the UPDATE_FRAMEWORK call in `ExamplesTest`s.
>
>
> Diffs
> -----
>
> src/tests/script.cpp 2e50861bf40ceeaf6a40476a742e6e82c23ba86f
>
>
> Diff: https://reviews.apache.org/r/70814/diff/2/
>
>
> Testing
> -------
>
> make check
>
> NOTE: without this change it is not possible to subscribe the java example framework with a role/roles other than `*`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70814: Replaced a set of single '*' role in
SCRIPT_TEST ACL with ANY.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70814/
-----------------------------------------------------------
(Updated June 12, 2019, 4:34 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
Replaced a set of single '*' role in SCRIPT_TEST ACL with ANY.
Repository: mesos
Description (updated)
-------
This patch changes the roles set in the ACL used by SCRIPT_TESTs for the
`register_frameworks` action from a single wildcard role (which is not
treated by the local authorizer in any special way, i.e. only wildcard
is allowed) to `ANY`. This is needed for adding and removing roles via
the UPDATE_FRAMEWORK call in `ExamplesTest`s.
Diffs (updated)
-----
src/tests/script.cpp 2e50861bf40ceeaf6a40476a742e6e82c23ba86f
Diff: https://reviews.apache.org/r/70814/diff/2/
Changes: https://reviews.apache.org/r/70814/diff/1-2/
Testing
-------
make check
NOTE: without this change it is not possible to subscribe the java example framework with a role/roles other than `*`
Thanks,
Andrei Sekretenko