[GitHub] [inlong] gong commented on a diff in pull request #6165: [INLONG-6160][Sort] Support dynamic partition for KafkaLoadNode

[GitBox <gi...@apache.org>]

gong commented on code in PR #6165:
URL: https://github.com/apache/inlong/pull/6165#discussion_r995688516


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/KafkaLoadNode.java:
##########
@@ -157,6 +173,12 @@ public Map<String, String> tableOptions() {
                 if (StringUtils.isNotBlank(topicPattern)) {
                     options.put("topic-pattern", topicPattern);
                 }
+                if (StringUtils.isNotBlank(sinkPartitioner)) {
+                    options.put("sink.partitioner", sinkPartitioner);
+                }
+                if (StringUtils.isNotBlank(partitionPattern)) {
+                    options.put("sink.multiple.partition-pattern", partitionPattern);

Review Comment:
   Maybe, optional option  can be passed by properties object. we don't need change construction method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org