You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/09/09 03:41:52 UTC
[GitHub] [flink] JingsongLi opened a new pull request #17207: [FLINK-22901][table] Introduce getUpsertKeys in FlinkRelMetadataQuery
JingsongLi opened a new pull request #17207:
URL: https://github.com/apache/flink/pull/17207
Cherry-pick #16096
## What is the purpose of the change
For fix FLINK-20374, we need to resolve streaming computation disorder. we need to introduce a change log upsert keys, this is not unique keys.
```
/**
* Determines the set of change log upsert minimal keys for this expression. A key is
* represented as an {@link org.apache.calcite.util.ImmutableBitSet}, where each bit position
* represents a 0-based output column ordinal.
*
* <p>Different from the unique keys: In distributed streaming computing, one record may be
* divided into RowKind.UPDATE_BEFORE and RowKind.UPDATE_AFTER. If a key changing join is
* connected downstream, the two records will be divided into different tasks, resulting in
* disorder. In this case, the downstream cannot rely on the order of the original key. So in
* this case, it has unique keys in the traditional sense, but it doesn't have change log upsert
* keys.
*
* @return set of keys, or null if this information cannot be determined (whereas empty set
* indicates definitely no keys at all)
*/
public Set<ImmutableBitSet> getChangeLogUpsertKeys(RelNode rel);
```
## Brief change log
- Introduce `FlinkRelMdChangeLogUpsertKeys`
- Introduce `FlinkRelMdChangeLogUpsertKeysTest`
## Verifying this change
`FlinkRelMdChangeLogUpsertKeysTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17207: [FLINK-22901][table-planner-blink] Introduce getUpsertKeys in FlinkRelMetadataQuery
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17207:
URL: https://github.com/apache/flink/pull/17207#issuecomment-915741202
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5 (Thu Sep 09 03:55:55 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17207: [FLINK-22901][table-planner-blink] Introduce getUpsertKeys in FlinkRelMetadataQuery
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17207:
URL: https://github.com/apache/flink/pull/17207#issuecomment-915750810
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23818",
"triggerID" : "4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23818)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #17207: [FLINK-22901][table-planner-blink] Introduce getUpsertKeys in FlinkRelMetadataQuery
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #17207:
URL: https://github.com/apache/flink/pull/17207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17207: [FLINK-22901][table-planner-blink] Introduce getUpsertKeys in FlinkRelMetadataQuery
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17207:
URL: https://github.com/apache/flink/pull/17207#issuecomment-915750810
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17207: [FLINK-22901][table-planner-blink] Introduce getUpsertKeys in FlinkRelMetadataQuery
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17207:
URL: https://github.com/apache/flink/pull/17207#issuecomment-915750810
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23818",
"triggerID" : "4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4f8b0f5ad64d4fe7c998042ec2b6b1ecec714be5 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=23818)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org