You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "JBert (Created) (JIRA)" <ji...@apache.org> on 2012/03/05 10:39:57 UTC
[jira] [Created] (FELIX-3373) File install logging doesn't notify
user of important errors
File install logging doesn't notify user of important errors
------------------------------------------------------------
Key: FELIX-3373
URL: https://issues.apache.org/jira/browse/FELIX-3373
Project: Felix
Issue Type: Bug
Components: File Install
Affects Versions: fileinstall-3.1.10
Reporter: JBert
When a bundle cannot be installed, no error is added to the log. Similarly, problems with jarring a directory are not logged as errors.
At the same time, logging is disabled by default. I would expect it to be set to the ERROR level, and only log important errors once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-3373) File install logging doesn't notify
user of important errors
Posted by "JBert (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222251#comment-13222251 ]
JBert commented on FELIX-3373:
------------------------------
I'll create a patch later this day which fixes this for the trunk version.
> File install logging doesn't notify user of important errors
> ------------------------------------------------------------
>
> Key: FELIX-3373
> URL: https://issues.apache.org/jira/browse/FELIX-3373
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-3.1.10
> Reporter: JBert
> Labels: logging
>
> When a bundle cannot be installed, no error is added to the log. Similarly, problems with jarring a directory are not logged as errors.
> At the same time, logging is disabled by default. I would expect it to be set to the ERROR level, and only log important errors once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3373) File install logging doesn't notify
user of important errors
Posted by "Jacobs Bert (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacobs Bert updated FELIX-3373:
-------------------------------
Attachment: fileinstall-logging.patch
I've attached a patch which changes
the following things:
- By default, the component produces no log output. I would expect
that errors are important enough that they should be offered to the
logging system, hence I changed DirectoryWatcher to default to
LOG_ERROR.
- If a Configuration from the config-admin contains no log settings, I
altered the code to use the global log level as a default. Vice versa,
a Configuration can still override the global log level.
- Stuff like corrupt bundles may simply go unnoticed because those are
logged as warnings. I've altered the logging level for non-recoverable
situations to see everything of interest as an error.
> File install logging doesn't notify user of important errors
> ------------------------------------------------------------
>
> Key: FELIX-3373
> URL: https://issues.apache.org/jira/browse/FELIX-3373
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-3.1.10
> Reporter: Jacobs Bert
> Labels: logging
> Attachments: fileinstall-logging.patch
>
>
> When a bundle cannot be installed, no error is added to the log. Similarly, problems with jarring a directory are not logged as errors.
> At the same time, logging is disabled by default. I would expect it to be set to the ERROR level, and only log important errors once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3373) File install logging doesn't notify
user of important errors
Posted by "Jacobs Bert (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacobs Bert updated FELIX-3373:
-------------------------------
Attachment: (was: fileinstall-logging.patch)
> File install logging doesn't notify user of important errors
> ------------------------------------------------------------
>
> Key: FELIX-3373
> URL: https://issues.apache.org/jira/browse/FELIX-3373
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-3.1.10
> Reporter: Jacobs Bert
> Labels: logging
>
> When a bundle cannot be installed, no error is added to the log. Similarly, problems with jarring a directory are not logged as errors.
> At the same time, logging is disabled by default. I would expect it to be set to the ERROR level, and only log important errors once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-3373) File install logging doesn't notify
user of important errors
Posted by "JBert (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
JBert updated FELIX-3373:
-------------------------
Attachment: fileinstall-logging.patch
Added patch file.
This patch does 3 things:
-It changes the default log level to ERROR.
-If the log level is set using the bundle context or a system property, this setting will become the default log level for all watchers, this according to the principle of least surprise. Configurations from the config admin can still override this value.
-Some logging statements got their severity raised from WARNING to ERROR because fileinstall didn't actually handle the problem, and hence might be important to the user. I've checked that these occur only once, in an effort to be not too verbose.
> File install logging doesn't notify user of important errors
> ------------------------------------------------------------
>
> Key: FELIX-3373
> URL: https://issues.apache.org/jira/browse/FELIX-3373
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-3.1.10
> Reporter: JBert
> Labels: logging
> Attachments: fileinstall-logging.patch
>
>
> When a bundle cannot be installed, no error is added to the log. Similarly, problems with jarring a directory are not logged as errors.
> At the same time, logging is disabled by default. I would expect it to be set to the ERROR level, and only log important errors once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-3373) File install logging doesn't notify
user of important errors
Posted by "Guillaume Nodet (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved FELIX-3373.
------------------------------------
Resolution: Fixed
Fix Version/s: fileinstall-3.1.12
Assignee: Guillaume Nodet
> File install logging doesn't notify user of important errors
> ------------------------------------------------------------
>
> Key: FELIX-3373
> URL: https://issues.apache.org/jira/browse/FELIX-3373
> Project: Felix
> Issue Type: Bug
> Components: File Install
> Affects Versions: fileinstall-3.1.10
> Reporter: Bert Jacobs
> Assignee: Guillaume Nodet
> Labels: logging
> Fix For: fileinstall-3.1.12
>
> Attachments: fileinstall-logging.patch
>
>
> When a bundle cannot be installed, no error is added to the log. Similarly, problems with jarring a directory are not logged as errors.
> At the same time, logging is disabled by default. I would expect it to be set to the ERROR level, and only log important errors once.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira