You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2009/08/19 14:20:14 UTC

[jira] Issue Comment Edited: (SOLR-1335) load core properties from a properties file

    [ https://issues.apache.org/jira/browse/SOLR-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745028#action_12745028 ] 

Noble Paul edited comment on SOLR-1335 at 8/19/09 5:19 AM:
-----------------------------------------------------------

bq.Error prone? I don't buy that. It's the same as setting a name in a .properties file - no more error prone than that. 



these properties files are separately shipped and the developer decides what are the properties. 

bq.Global properties - yes, but you can "namespace" them... -Dcore1name.master=false -Dcore2name.master=true kinda stuff.

is this clean? 

The system properties are available across the JVM . Why do you want a system wide property for something that is only used in solrconfig/schema? There is a chance of it conflicting with other system properties too.

I do not see the reason against the properties. It is more like your ant script loading external properties from a properties file. Nobody is mandating the use of it . If one needs to clean up the deployment he is welcome to use it.

      was (Author: noble.paul):
    bq.Error prone? I don't buy that. It's the same as setting a name in a .properties file - no more error prone than that. 



these properties files are separately shipped and the developer decides what are the properties. 

bq.Global properties - yes, but you can "namespace" them... -Dcore1name.master=false -Dcore2name.master=true kinda stuff.

is this clean? 

I do not see the reason against the properties. It is more like your ant script loading external properties from a properties file. Nobody is mandating the use of it . If one needs to clean up the deployment he is welcome to use it.
  
> load core properties from a properties file
> -------------------------------------------
>
>                 Key: SOLR-1335
>                 URL: https://issues.apache.org/jira/browse/SOLR-1335
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1335.patch, SOLR-1335.patch, SOLR-1335.patch
>
>
> There are  few ways of loading properties in runtime,
> # using env property using in the command line
> # if you use a multicore drop it in the solr.xml
> if not , the only way is to  keep separate solrconfig.xml for each instance.  #1 is error prone if the user fails to start with the correct system property. 
> In our case we have four different configurations for the same deployment  . And we have to disable replication of solrconfig.xml. 
> It would be nice if I can distribute four properties file so that our ops can drop  the right one and start Solr. Or it is possible for the operations to edit a properties file  but it is risky to edit solrconfig.xml if he does not understand solr
> I propose a properties file in the instancedir as solrcore.properties . If present would be loaded and added as core specific properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.