You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/20 09:57:22 UTC
[GitHub] [airflow] phanikumv opened a new pull request, #24559: Add on_kill() to kill Trino query if Airflow task is killed
phanikumv opened a new pull request, #24559:
URL: https://github.com/apache/airflow/pull/24559
This PR is a follow up to PR #24415.
It add on_kill method to the TrinoOperator to kill Trino query if Airflow task is killed
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #24559: Add on_kill() to kill Trino query if Airflow task is killed
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #24559:
URL: https://github.com/apache/airflow/pull/24559#discussion_r901924764
##########
airflow/providers/trino/operators/trino.py:
##########
@@ -79,3 +81,18 @@ def execute(self, context: 'Context') -> None:
self.hook.run(
sql=self.sql, autocommit=self.autocommit, parameters=self.parameters, handler=self.handler
)
+
+ def on_kill(self) -> None:
+ if self.hook is not None and isinstance(self.hook, TrinoHook):
Review Comment:
The following might be sufficient
```suggestion
if isinstance(self.hook, TrinoHook):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #24559: Add on_kill() to kill Trino query if Airflow task is killed
Posted by GitBox <gi...@apache.org>.
kaxil merged PR #24559:
URL: https://github.com/apache/airflow/pull/24559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24559: Add on_kill() to kill Trino query if Airflow task is killed
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24559:
URL: https://github.com/apache/airflow/pull/24559#issuecomment-1160402032
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #24559: Add on_kill() to kill Trino query if Airflow task is killed
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #24559:
URL: https://github.com/apache/airflow/pull/24559#discussion_r901924408
##########
airflow/providers/trino/operators/trino.py:
##########
@@ -79,3 +81,18 @@ def execute(self, context: 'Context') -> None:
self.hook.run(
sql=self.sql, autocommit=self.autocommit, parameters=self.parameters, handler=self.handler
)
+
+ def on_kill(self) -> None:
+ if self.hook is not None and isinstance(self.hook, TrinoHook):
+ query_id = "'" + self.hook.query_id + "'"
Review Comment:
Does the following work?
```suggestion
query_id = f"'{self.hook.query_id}'"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org