You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/18 15:10:45 UTC
[GitHub] [beam] scwhittle opened a new pull request #17122: [BEAM-13015] Change DirectObserver to use a fair lock when blocking on appending to the underlying stream.
scwhittle opened a new pull request #17122:
URL: https://github.com/apache/beam/pull/17122
This both prevents delaying some
requests unfairly and ensures that only one thread is polling isReady
which otherwise can be expensive.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle edited a comment on pull request #17122: [BEAM-13015] Change DirectObserver to use a fair lock when blocking on appending to the underlying stream.
Posted by GitBox <gi...@apache.org>.
scwhittle edited a comment on pull request #17122:
URL: https://github.com/apache/beam/pull/17122#issuecomment-1072482157
R: @lukecwik Is this what you were thinking to fix the excessive isReady cpu? I didn't just use a synchronized block so it would be fair. I kept the existing syncronization instead of just using the new lock since I wasn't sure if we required that synchronization on the observer for safe usage of the underlying observer elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #17122: [BEAM-13015] Change DirectObserver to use a fair lock when blocking on appending to the underlying stream.
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #17122:
URL: https://github.com/apache/beam/pull/17122#issuecomment-1079479941
I filed https://issues.apache.org/jira/browse/BEAM-14184 to track this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #17122: [BEAM-13015] Change DirectObserver to use a fair lock when blocking on appending to the underlying stream.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #17122:
URL: https://github.com/apache/beam/pull/17122#issuecomment-1072482157
R: @lukecwik Is this what you were thinking to fix the excessive isReady cpu?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #17122: [BEAM-13015] Change DirectObserver to use a fair lock when blocking on appending to the underlying stream.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #17122:
URL: https://github.com/apache/beam/pull/17122#issuecomment-1072660188
Realized I dropped the checking isReady every 100 messages, rewriting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle closed pull request #17122: [BEAM-13015] Change DirectObserver to use a fair lock when blocking on appending to the underlying stream.
Posted by GitBox <gi...@apache.org>.
scwhittle closed pull request #17122:
URL: https://github.com/apache/beam/pull/17122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org