You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/12/17 23:26:22 UTC
Review Request 71923: SSL Socket: Guarded against downgrade while
unimplemented.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71923/
-----------------------------------------------------------
Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
Bugs: MESOS-10072
https://issues.apache.org/jira/browse/MESOS-10072
Repository: mesos
Description
-------
The SSL downgrade feature present in our libevent-SSL socket
is currently not supported on the plain-OpenSSL socket.
For this reason, we make sure to check the related flag and
prevent the related tests from running.
Diffs
-----
3rdparty/libprocess/src/openssl.cpp 8aab5acfb4bf3aa94625eaa7157714eca98940f7
3rdparty/libprocess/src/tests/ssl_tests.cpp 3f1d1039bfdd686e43395c55c8edf6ab863ca7ac
Diff: https://reviews.apache.org/r/71923/diff/1/
Testing
-------
cmake --build . --target check
Thanks,
Joseph Wu
Re: Review Request 71923: SSL Socket: Guarded against downgrade while
unimplemented.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71923/#review219048
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Dec. 17, 2019, 11:26 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71923/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2019, 11:26 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-10072
> https://issues.apache.org/jira/browse/MESOS-10072
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The SSL downgrade feature present in our libevent-SSL socket
> is currently not supported on the plain-OpenSSL socket.
>
> For this reason, we make sure to check the related flag and
> prevent the related tests from running.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/openssl.cpp 8aab5acfb4bf3aa94625eaa7157714eca98940f7
> 3rdparty/libprocess/src/tests/ssl_tests.cpp 3f1d1039bfdd686e43395c55c8edf6ab863ca7ac
>
>
> Diff: https://reviews.apache.org/r/71923/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 71923: SSL Socket: Guarded against downgrade while
unimplemented.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71923/#review219050
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71659, 71764, 71660, 71661, 71662, 71663, 71664, 71665, 71666, 71790, 71923]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Dec. 17, 2019, 11:26 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71923/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2019, 11:26 p.m.)
>
>
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till Toenshoff.
>
>
> Bugs: MESOS-10072
> https://issues.apache.org/jira/browse/MESOS-10072
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The SSL downgrade feature present in our libevent-SSL socket
> is currently not supported on the plain-OpenSSL socket.
>
> For this reason, we make sure to check the related flag and
> prevent the related tests from running.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/openssl.cpp 8aab5acfb4bf3aa94625eaa7157714eca98940f7
> 3rdparty/libprocess/src/tests/ssl_tests.cpp 3f1d1039bfdd686e43395c55c8edf6ab863ca7ac
>
>
> Diff: https://reviews.apache.org/r/71923/diff/1/
>
>
> Testing
> -------
>
> cmake --build . --target check
>
>
> Thanks,
>
> Joseph Wu
>
>