You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2016/01/12 21:44:35 UTC
[Issue 126787] New: fix unit tests on windows
https://bz.apache.org/ooo/show_bug.cgi?id=126787
Issue ID: 126787
Issue Type: PATCH
Summary: fix unit tests on windows
Product: Build Tools
Version: 4.2.0-dev
Hardware: All
OS: Windows, all
Status: CONFIRMED
Severity: Normal
Priority: P5 (lowest)
Component: code
Assignee: issues@openoffice.apache.org
Reporter: j.nitschke@ok.de
Attachment #85248 review?
Flags:
Created attachment 85248
--> https://bz.apache.org/ooo/attachment.cgi?id=85248&action=edit
remove prewin.h and postwin.h in sal unittests
build process on windows is currently broken[1]
some unit tests in sal includes headers from tools which depends on sal
(circular dependencies)[2]
said headers are prewin.h and postwin.h which frame windows.h includes
I got no win build environment, but looking at the files I don't think they are
needed for the basic functionality sal (system abstraction layer) provides
would be happy to know if someone knows more about prewin and postwin
here a patch which removes the includes
if someone with a win build environment could test it or if no time let our
buildbot do the work. would be great
[1] https://ci.apache.org/builders/aoo-win7/builds/139
[2]
https://mail-archives.apache.org/mod_mbox/openoffice-dev/201512.mbox/%3C56804CDE.2020201%40ok.de%3E
note: all this is related to the work in Issue 125003 - Integrate GoogleTest
unit test framework for general usage in the build environment
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126787] fix unit tests on windows
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126787
damjan@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |damjan@apache.org
Keywords| |regression
--- Comment #1 from damjan@apache.org ---
I probably added the patch that causes this problem in commit 1710853 with this
message:
Fix some main/sal unit tests on Windows, remove unneeded OOO_SUBSEQUENT_TESTS,
and run all that pass during the build.
In order words, this patch was what fixed building unit tests in Windows; I am
not sure why it is breaking for you. I'll do an "svn update" and rebuild from
scratch, then report back with the details of my build environment.
--
You are receiving this mail because:
You are the assignee for the issue.
review requested: [Issue 126787] fix unit tests on windows :
[Attachment 85248] remove prewin.h and postwin.h in sal unittests
Posted by bu...@apache.org.
j.nitschke@ok.de has asked for review:
Issue 126787: fix unit tests on windows
https://bz.apache.org/ooo/show_bug.cgi?id=126787
Attachment 85248: remove prewin.h and postwin.h in sal unittests
https://bz.apache.org/ooo/attachment.cgi?id=85248&action=edit
--- Description ---
build process on windows is currently broken[1]
some unit tests in sal includes headers from tools which depends on sal
(circular dependencies)[2]
said headers are prewin.h and postwin.h which frame windows.h includes
I got no win build environment, but looking at the files I don't think they are
needed for the basic functionality sal (system abstraction layer) provides
would be happy to know if someone knows more about prewin and postwin
here a patch which removes the includes
if someone with a win build environment could test it or if no time let our
buildbot do the work. would be great
[1] https://ci.apache.org/builders/aoo-win7/builds/139
[2]
https://mail-archives.apache.org/mod_mbox/openoffice-dev/201512.mbox/%3C56804CD
E.2020201%40ok.de%3E
note: all this is related to the work in Issue 125003 - Integrate GoogleTest
unit test framework for general usage in the build environment
[Issue 126787] fix unit tests on windows
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126787
Marcus <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 126787] fix unit tests on windows
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=126787
damjan@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Issue Type|PATCH |DEFECT
Target Milestone|--- |4.2.0
Latest|--- |4.2.0-dev
Confirmation in| |
--- Comment #2 from damjan@apache.org ---
I can reproduce the problem on Windows, and your patch fixes it. I didn't catch
it before because I didn't do an incompatible rebuild so the previously built
tools was being used.
Patch committed in revision 1727413. Thank you very much for your contribution!
#i126787# fix unit tests on Windows
Fix a regression caused by r1710853 and which always existed in some files,
where <prewin.h> and <postwin.h> were being included before and after
<windows.h>, yet unavailable as the tools module isn't built (and can't be)
before sal.
Patch by: j.nitschke at ok.de
Review by: me
--
You are receiving this mail because:
You are the assignee for the issue.