You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@camel.apache.org by chessami92 <ch...@gmail.com> on 2014/05/07 00:05:22 UTC
Re: Calculation of in-flight messages in DefaultShutdownStrategy
So I got a chance to look at this again and I think the root cause is an
issue with how the AggregateProcessor responds to prepareShutdown. I think
it responds correctely, but the DefaultShutdownStrategy does not consider
the fact that doing the prepareShutdown routine may actually spawn more
messages coming out of some services like the AggregateProcessor.
Take a look at
https://github.com/chessami92/camel/compare/camel-2.13.x...features%2Fbetter-route-shutdown-deferral
to see the test that I added and how I fixed the problem in the
DefaultShutdownStrategy and let me know what you think.
I can do a pull request if you think this is something that should be
included in camel core. I know there isn't a bug for it out there, so let me
know if I need to make one first, or if you even consider this behavior a
bug.
--
View this message in context: http://camel.465427.n5.nabble.com/Calculation-of-in-flight-messages-in-DefaultShutdownStrategy-tp5747034p5750935.html
Sent from the Camel - Users mailing list archive at Nabble.com.
Re: Calculation of in-flight messages in DefaultShutdownStrategy
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
I logged a ticket
https://issues.apache.org/jira/browse/CAMEL-7528
On Wed, May 7, 2014 at 7:24 AM, Claus Ibsen <cl...@gmail.com> wrote:
> Hi
>
> Yeah sure we love contributions. So fell free to log a JIRA ticket and
> submit a patch / PR.
> http://camel.apache.org/contributing
>
> Another solution could maybe have been for the aggregator repositories
> to report back how many exchanges they have during the prepare
> shutdown. Then the memory based repos could report how many the
> currently have etc.
>
> The same problem is also in the resequencer EIP as its also stateful.
> Those are the only 2 eips afair.
>
>
>
> On Wed, May 7, 2014 at 12:05 AM, chessami92 <ch...@gmail.com> wrote:
>> So I got a chance to look at this again and I think the root cause is an
>> issue with how the AggregateProcessor responds to prepareShutdown. I think
>> it responds correctely, but the DefaultShutdownStrategy does not consider
>> the fact that doing the prepareShutdown routine may actually spawn more
>> messages coming out of some services like the AggregateProcessor.
>>
>> Take a look at
>> https://github.com/chessami92/camel/compare/camel-2.13.x...features%2Fbetter-route-shutdown-deferral
>> to see the test that I added and how I fixed the problem in the
>> DefaultShutdownStrategy and let me know what you think.
>>
>> I can do a pull request if you think this is something that should be
>> included in camel core. I know there isn't a bug for it out there, so let me
>> know if I need to make one first, or if you even consider this behavior a
>> bug.
>>
>>
>>
>> --
>> View this message in context: http://camel.465427.n5.nabble.com/Calculation-of-in-flight-messages-in-DefaultShutdownStrategy-tp5747034p5750935.html
>> Sent from the Camel - Users mailing list archive at Nabble.com.
>
>
>
> --
> Claus Ibsen
> -----------------
> Red Hat, Inc.
> Email: cibsen@redhat.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen
> hawtio: http://hawt.io/
> fabric8: http://fabric8.io/
--
Claus Ibsen
-----------------
Red Hat, Inc.
Email: cibsen@redhat.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
hawtio: http://hawt.io/
fabric8: http://fabric8.io/
Re: Calculation of in-flight messages in DefaultShutdownStrategy
Posted by Claus Ibsen <cl...@gmail.com>.
Hi
Yeah sure we love contributions. So fell free to log a JIRA ticket and
submit a patch / PR.
http://camel.apache.org/contributing
Another solution could maybe have been for the aggregator repositories
to report back how many exchanges they have during the prepare
shutdown. Then the memory based repos could report how many the
currently have etc.
The same problem is also in the resequencer EIP as its also stateful.
Those are the only 2 eips afair.
On Wed, May 7, 2014 at 12:05 AM, chessami92 <ch...@gmail.com> wrote:
> So I got a chance to look at this again and I think the root cause is an
> issue with how the AggregateProcessor responds to prepareShutdown. I think
> it responds correctely, but the DefaultShutdownStrategy does not consider
> the fact that doing the prepareShutdown routine may actually spawn more
> messages coming out of some services like the AggregateProcessor.
>
> Take a look at
> https://github.com/chessami92/camel/compare/camel-2.13.x...features%2Fbetter-route-shutdown-deferral
> to see the test that I added and how I fixed the problem in the
> DefaultShutdownStrategy and let me know what you think.
>
> I can do a pull request if you think this is something that should be
> included in camel core. I know there isn't a bug for it out there, so let me
> know if I need to make one first, or if you even consider this behavior a
> bug.
>
>
>
> --
> View this message in context: http://camel.465427.n5.nabble.com/Calculation-of-in-flight-messages-in-DefaultShutdownStrategy-tp5747034p5750935.html
> Sent from the Camel - Users mailing list archive at Nabble.com.
--
Claus Ibsen
-----------------
Red Hat, Inc.
Email: cibsen@redhat.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen
hawtio: http://hawt.io/
fabric8: http://fabric8.io/