You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/06/18 16:54:04 UTC

[GitHub] [tomcat] bekionel opened a new pull request #304: Use https URLs when possible

bekionel opened a new pull request #304:
URL: https://github.com/apache/tomcat/pull/304


   - This is a follow up to https://github.com/apache/tomcat/commit/82f764ccec2


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf commented on pull request #304: Use https URLs when possible

Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #304:
URL: https://github.com/apache/tomcat/pull/304#issuecomment-672066549


   Closing as this PR cannot be applied as-is. Anyone interested in following through on this should start a discussion on the dev list as per my previous comment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf commented on pull request #304: Use https URLs when possible

Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #304:
URL: https://github.com/apache/tomcat/pull/304#issuecomment-647466028


   In its current state applying this PR will trigger build failures (license header validation will fail).
   
   I am also not convinced that the effort required to convert the link in every license header to https is worth the effort. However, if the community does decide to do this - and a conversation on the dev list is where/how that decision should be made - then all the files need to be changed, not just a sub-set.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf closed pull request #304: Use https URLs when possible

Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #304:
URL: https://github.com/apache/tomcat/pull/304


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org