You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/06/18 23:29:25 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on issue #7720: [SQL Lab] Add JSON modal when clicking on cells with JSON objects

codecov-io edited a comment on issue #7720: [SQL Lab] Add JSON modal when clicking on cells with JSON objects
URL: https://github.com/apache/incubator-superset/pull/7720#issuecomment-502882518
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7720?src=pr&el=h1) Report
   > Merging [#7720](https://codecov.io/gh/apache/incubator-superset/pull/7720?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5864ddc07944c9b6f4a235a4be604a93976e30af?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `60%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7720/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7720?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7720      +/-   ##
   ==========================================
   - Coverage   65.77%   65.76%   -0.01%     
   ==========================================
     Files         459      459              
     Lines       21911    21936      +25     
     Branches     2410     2414       +4     
   ==========================================
   + Hits        14411    14426      +15     
   - Misses       7379     7389      +10     
     Partials      121      121
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7720?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...src/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7720/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0ZpbHRlcmFibGVUYWJsZS9GaWx0ZXJhYmxlVGFibGUuanN4) | `83.56% <60%> (-4.87%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7720?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7720?src=pr&el=footer). Last update [5864ddc...35ef47b](https://codecov.io/gh/apache/incubator-superset/pull/7720?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org