You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/07/14 16:25:00 UTC
[GitHub] flink pull request #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly ...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2248
[FLINK-4213] [gelly] Provide CombineHint in Gelly algorithms
`VertexDegrees` has changed from using a `ReduceFunction` to using a `GroupReduceFunction` as in directed `TriangleListing`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 4213_provide_combinehint_in_gelly_algorithms
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2248
----
commit 2a8e5c708acefa881223bb3c8a6371bd5bb6ea9b
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-07-14T13:39:02Z
[FLINK-4213] [gelly] Provide CombineHint in Gelly algorithms
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly algorit...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2248
Depends how much faster we can make sorting in the `NormalizedKeySorter` :)
I'll keep working on a comparison, I've been running into the deadlock in FLINK-4163.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly algorit...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2248
Yes, and the job plan attached to the ticket shows the only combine as a "Sorted Combine" (from distinct).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly algorit...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2248
Does the deadlock occur only with the combiner, or also with the sorter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2248: [FLINK-4213] [gelly] Provide CombineHint in Gelly algorit...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2248
Looks good to me.
How much faster does it get with the hash combiner?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---