You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficcontrol.apache.org by Zach Hoffman <zr...@apache.org> on 2021/10/26 14:57:40 UTC
Making Use of GitHub Triage role
Hi ATC,
Besides the Maintain GitHub role (which ASF committers get), there is
a Triage role that lets the user:
- Apply/dismiss labels
- Close, reopen, and assign all issues and pull requests
- Apply milestones
- Mark duplicate issues and pull requests
- Request pull request reviews
Like most Apache repos, ours as a .asf.yaml file
<https://s.apache.org/asfyamltriage>, and any GitHub user added to a
`github.collaborators` list in our .asf.yaml will be granted the
GitHub Triage role for our repo only, until that username is removed
from the list.
We could potentially take advantage of this feature by granting a
Triage role to active ATC contributors who are not (yet) committers,
if we think they could be useful for applying labels to Issues and PRs
or for closing stale Issues that no longer apply.
Who would we want to grant the triage role? Perhaps non-committer
contributors who have over 5 commits in the past month? And then maybe
we could later remove that role for contributors who no longer meet
that mark.
-Zach
Re: Making Use of GitHub Triage role
Posted by Zach Hoffman <zr...@apache.org>.
The PR is out: https://github.com/apache/trafficcontrol/pull/6424
It goes by Issue-closing PRs, not just PRs. For this reason, I lowered
the monthly commit requirement from 5 to 2. Feedback is welcome here
or on the PR.
-Zach
On Tue, Nov 16, 2021 at 9:46 AM Jeremy Mitchell <mi...@gmail.com> wrote:
>
> +1
>
> On Tue, Nov 16, 2021 at 9:42 AM ocket 8888 <oc...@gmail.com> wrote:
>
> > +1
> >
> > On Tue, Oct 26, 2021 at 8:57 AM Zach Hoffman <zr...@apache.org> wrote:
> > >
> > > Hi ATC,
> > >
> > > Besides the Maintain GitHub role (which ASF committers get), there is
> > > a Triage role that lets the user:
> > >
> > > - Apply/dismiss labels
> > > - Close, reopen, and assign all issues and pull requests
> > > - Apply milestones
> > > - Mark duplicate issues and pull requests
> > > - Request pull request reviews
> > >
> > > Like most Apache repos, ours as a .asf.yaml file
> > > <https://s.apache.org/asfyamltriage>, and any GitHub user added to a
> > > `github.collaborators` list in our .asf.yaml will be granted the
> > > GitHub Triage role for our repo only, until that username is removed
> > > from the list.
> > >
> > > We could potentially take advantage of this feature by granting a
> > > Triage role to active ATC contributors who are not (yet) committers,
> > > if we think they could be useful for applying labels to Issues and PRs
> > > or for closing stale Issues that no longer apply.
> > >
> > > Who would we want to grant the triage role? Perhaps non-committer
> > > contributors who have over 5 commits in the past month? And then maybe
> > > we could later remove that role for contributors who no longer meet
> > > that mark.
> > >
> > > -Zach
> >
Re: Making Use of GitHub Triage role
Posted by Jeremy Mitchell <mi...@gmail.com>.
+1
On Tue, Nov 16, 2021 at 9:42 AM ocket 8888 <oc...@gmail.com> wrote:
> +1
>
> On Tue, Oct 26, 2021 at 8:57 AM Zach Hoffman <zr...@apache.org> wrote:
> >
> > Hi ATC,
> >
> > Besides the Maintain GitHub role (which ASF committers get), there is
> > a Triage role that lets the user:
> >
> > - Apply/dismiss labels
> > - Close, reopen, and assign all issues and pull requests
> > - Apply milestones
> > - Mark duplicate issues and pull requests
> > - Request pull request reviews
> >
> > Like most Apache repos, ours as a .asf.yaml file
> > <https://s.apache.org/asfyamltriage>, and any GitHub user added to a
> > `github.collaborators` list in our .asf.yaml will be granted the
> > GitHub Triage role for our repo only, until that username is removed
> > from the list.
> >
> > We could potentially take advantage of this feature by granting a
> > Triage role to active ATC contributors who are not (yet) committers,
> > if we think they could be useful for applying labels to Issues and PRs
> > or for closing stale Issues that no longer apply.
> >
> > Who would we want to grant the triage role? Perhaps non-committer
> > contributors who have over 5 commits in the past month? And then maybe
> > we could later remove that role for contributors who no longer meet
> > that mark.
> >
> > -Zach
>
Re: Making Use of GitHub Triage role
Posted by ocket 8888 <oc...@gmail.com>.
+1
On Tue, Oct 26, 2021 at 8:57 AM Zach Hoffman <zr...@apache.org> wrote:
>
> Hi ATC,
>
> Besides the Maintain GitHub role (which ASF committers get), there is
> a Triage role that lets the user:
>
> - Apply/dismiss labels
> - Close, reopen, and assign all issues and pull requests
> - Apply milestones
> - Mark duplicate issues and pull requests
> - Request pull request reviews
>
> Like most Apache repos, ours as a .asf.yaml file
> <https://s.apache.org/asfyamltriage>, and any GitHub user added to a
> `github.collaborators` list in our .asf.yaml will be granted the
> GitHub Triage role for our repo only, until that username is removed
> from the list.
>
> We could potentially take advantage of this feature by granting a
> Triage role to active ATC contributors who are not (yet) committers,
> if we think they could be useful for applying labels to Issues and PRs
> or for closing stale Issues that no longer apply.
>
> Who would we want to grant the triage role? Perhaps non-committer
> contributors who have over 5 commits in the past month? And then maybe
> we could later remove that role for contributors who no longer meet
> that mark.
>
> -Zach