You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/06 16:05:29 UTC

[GitHub] [arrow] ArianaVillegas commented on a change in pull request #11798: ARROW-13579: Expose Create EmptyArray, EmptyRecordBatch and EmptyTable utility functions.

ArianaVillegas commented on a change in pull request #11798:
URL: https://github.com/apache/arrow/pull/11798#discussion_r763147483



##########
File path: cpp/src/arrow/compute/kernels/vector_selection.cc
##########
@@ -19,26 +19,21 @@
 #include <cstring>
 #include <limits>
 
-#include "arrow/array/array_base.h"
 #include "arrow/array/array_binary.h"
 #include "arrow/array/array_dict.h"
 #include "arrow/array/array_nested.h"
 #include "arrow/array/builder_primitive.h"
 #include "arrow/array/concatenate.h"
 #include "arrow/buffer_builder.h"
-#include "arrow/chunked_array.h"
 #include "arrow/compute/api_vector.h"
 #include "arrow/compute/kernels/common.h"
 #include "arrow/compute/kernels/util_internal.h"
 #include "arrow/extension_type.h"
-#include "arrow/record_batch.h"
 #include "arrow/result.h"
-#include "arrow/table.h"

Review comment:
       Well, as a previous suggestion I move the includes to util_internal, so in the future, we won't need to include RecordBatch/Table/ChukedArray files, just include util_internal.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org