You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/13 16:54:46 UTC
[jira] [Commented] (CLOUDSTACK-9158) Remove SLF4J
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055021#comment-15055021 ]
ASF GitHub Bot commented on CLOUDSTACK-9158:
--------------------------------------------
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1236
CLOUDSTACK-9158: Removed SLF4J, it's abundant due to log4j
In the entire project we use log4j, so why also use slf4j? I've removed slf4j and all references to it from the codebase.
Also I've let the top-level pom depend on log4j so not every project has to define it for itself.
Ping @remibergsma @DaanHoogland @miguelaferreira @wilderrodrigues @wido
Builds ok, running integration tests now!
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6:33.329s
[INFO] Finished at: Sun Dec 13 16:53:55 CET 2015
[INFO] Final Memory: 104M/813M
[INFO] ------------------------------------------------------------------------
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-9158
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1236.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1236
----
commit e7a6a0a38e36bc8deac7aa77b0aa624aa055bc1b
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-12-13T15:04:57Z
CLOUDSTACK-9158: Remove SLF4J, it's abundant due to log4j
----
> Remove SLF4J
> ------------
>
> Key: CLOUDSTACK-9158
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9158
> Project: CloudStack
> Issue Type: Sub-task
> Security Level: Public(Anyone can view this level - this is the default.)
> Reporter: Boris Schrijver
> Assignee: Boris Schrijver
>
> We're using log4j everywhere in the project. Therefore SLF4J is abundant.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)