[GitHub] [flink] nicoweidner commented on a change in pull request #16543: [FLINK-23417][tests] Harden MiniClusterITCase.testHandleBatchJobsWhenNotEnoughSlot

[GitBox <gi...@apache.org>]

nicoweidner commented on a change in pull request #16543:
URL: https://github.com/apache/flink/pull/16543#discussion_r673995958



##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java
##########
@@ -159,6 +160,8 @@ private void setupAndRunHandleJobsWhenNotEnoughSlots(ScheduleMode scheduleMode)
     private void runHandleJobsWhenNotEnoughSlots(final JobGraph jobGraph) throws Exception {
         final Configuration configuration = getDefaultConfiguration();
         configuration.setLong(JobManagerOptions.SLOT_REQUEST_TIMEOUT, 100L);
+        configuration.setLong(
+                ResourceManagerOptions.STANDALONE_CLUSTER_STARTUP_PERIOD_TIME, 10000L);

Review comment:
       The premise of the test confuses me: We run a job with parallelism 2 on a cluster that has only 1 slot available. Shouldn't we _expect_ to get the "request not fulfillable" failure instead of the slot request timeout? To test the timeout, wouldn't it make more sense to have a request that would be fulfillable, but slots are blocked with another task?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org