Re: [PR] GH-43187 [C++] Support is_in predicates for SimplifyWithGuarantee [arrow]

["larry98 (via GitHub)" <gi...@apache.org>]

larry98 commented on PR #43256:
URL: https://github.com/apache/arrow/pull/43256#issuecomment-2329707522

   @bkietz before I rebase these changes on top of https://github.com/apache/arrow/pull/43761, do you have any thoughts on the high level approach? Specifically
   - Any concerns with using the `SimplificationContext` unordered map to defer binding the simplified `is_in` exprs until all inequalities have been processed?
   - Any thoughts on how to use `ArrayStatistics` for this optimization? It appears that the statistics class was added, but they aren't computed anywhere. Also, transparently updating `ArrayStatistics::is_sorted` across calls to `SortIndices` and `Take` doesn't seem straightforward. Were you thinking that `ArrayStatistics::is_sorted` would be manually set by the caller?
   - It sounds like we're ok with storing the memoized sorted and unique value set in the kernel state, even though it's not used by the kernel?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org