You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/08 02:55:46 UTC
[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1524: [KYUUBI #1522] Pass the client ip to engine
wForget commented on a change in pull request #1524:
URL: https://github.com/apache/incubator-kyuubi/pull/1524#discussion_r764512473
##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSQLSessionManager.scala
##########
@@ -78,7 +79,7 @@ class SparkSQLSessionManager private (name: String, spark: SparkSession)
protocol,
user,
password,
- ipAddress,
Review comment:
> Seems the ipAddress of the kyuubi server is also useful if we deploy in ha. We can get the information which Kyuubi server opened the engine session.
Yes, but the current usage is more inclined to clientip, do we need to add an extra ip field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org