You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2002/01/13 05:02:43 UTC
make check output
would anyone have an objection to this patch to Makefile.in that makes
'make check' output 'FAILURE' if a test fails during make check's run,
rather than just printing nothing and as a result having the next test's
ouput on the same line?
-garrett
* Makefile.in (check): output 'FAILURE' when a test fails, since we
output 'SUCCESS' when it passes.
Index: ./Makefile.in
===================================================================
--- ./Makefile.in
+++ ./Makefile.in Sat Jan 12 23:36:42 2002
@@ -134,6 +134,7 @@
if ( cd $$progdir && $$runprog ) >> $$logfile ; then \
echo "SUCCESS" ; \
else \
+ echo "FAILURE" ; \
failed=yes; \
fi; \
echo "END: $$progbase" >> $$logfile ; \
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: make check output
Posted by Greg Stein <gs...@lyra.org>.
On Sun, Jan 13, 2002 at 12:02:43AM -0500, Garrett Rooney wrote:
> would anyone have an objection to this patch to Makefile.in that makes
> 'make check' output 'FAILURE' if a test fails during make check's run,
> rather than just printing nothing and as a result having the next test's
> ouput on the same line?
I'm surprised it wasn't there. (!)
I dunno much about the desired behavior of much of that "make check" stuff;
I just run it every now and then. Let's see what Ben or Karl have to say.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: make check output
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Sun, Jan 13, 2002 at 10:23:08PM +0100, Branko _ibej wrote:
> Heh, heh! This is exactly what I did in my tree while playing with the
> tests on Win32.
great minds think alike ;-)
> Committed in rev. 864.
cool, thanks.
-garrett
--
garrett rooney Unix was not designed to stop you from
rooneg@electricjellyfish.net doing stupid things, because that would
http://electricjellyfish.net/ stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: make check output
Posted by Branko Čibej <br...@xbc.nu>.
Garrett Rooney wrote:
>would anyone have an objection to this patch to Makefile.in that makes
>'make check' output 'FAILURE' if a test fails during make check's run,
>rather than just printing nothing and as a result having the next test's
>ouput on the same line?
>
>-garrett
>
>* Makefile.in (check): output 'FAILURE' when a test fails, since we
>output 'SUCCESS' when it passes.
>
>Index: ./Makefile.in
>===================================================================
>--- ./Makefile.in
>+++ ./Makefile.in Sat Jan 12 23:36:42 2002
>@@ -134,6 +134,7 @@
> if ( cd $$progdir && $$runprog ) >> $$logfile ; then \
> echo "SUCCESS" ; \
> else \
>+ echo "FAILURE" ; \
> failed=yes; \
> fi; \
> echo "END: $$progbase" >> $$logfile ; \
>
Heh, heh! This is exactly what I did in my tree while playing with the
tests on Win32.
Committed in rev. 864.
--
Brane �ibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org