[GitHub] [ignite-3] vladErmakov07 commented on a change in pull request #243: IGNITE-13668 Number native type support

[GitBox <gi...@apache.org>]

vladErmakov07 commented on a change in pull request #243:
URL: https://github.com/apache/ignite-3/pull/243#discussion_r681814607



##########
File path: modules/schema/src/main/java/org/apache/ignite/internal/schema/DecimalNativeType.java
##########
@@ -60,8 +60,7 @@ public int scale() {
     /** {@inheritDoc} */
     @Override public boolean mismatch(NativeType type) {
         return super.mismatch(type)
-            || precision < ((NumericNativeType)type).precision
-            || scale < ((NumericNativeType)type).scale;
+            || precision < ((DecimalNativeType)type).precision;

Review comment:
       I decided to check precision after scaling in RowAssembler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org