You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/09/27 15:49:52 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1175: chore(license): add ignore file/path configs to .rat-excludes
acelyc111 opened a new pull request, #1175:
URL: https://github.com/apache/incubator-pegasus/pull/1175
https://github.com/apache/incubator-pegasus/issues/823
adds ignore file/path configs to .rat-excludes
adds missing license header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1175: chore(license): add ignore file/path configs to .rat-excludes
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1175:
URL: https://github.com/apache/incubator-pegasus/pull/1175#discussion_r981422804
##########
.rat-excludes:
##########
@@ -1,12 +1,29 @@
-.*json
-.*in
-carrot
-sds/*
-linenoise/*
+.*go.sum
+.*csv
+.*npmigonre
+.*gtest.filter
+FindRT.cmake
+FindDL.cmake
+dsn_err_string.go
+rocskdb_err_string.go
+safe_strerror_posix.h
+autoresetevent.h
+autoreseteventcondvar.h
+benaphore.h
+bitfield.h
+rwlock.h
+sema.h
+copy_source.txt
+suite.*
+nfs_test_file.*
+build_config.h
+command.txt
+safe_strerror_posix.cpp
+autoref_ptr_test.cpp
+config-empty.ini
argh.h
-git_commit.h
-ssh-no-interactive
-scp-no-interactive
+linenoise/*
+sds/*
+.*patch
DISCLAIMER-WIP
-.rat-excludes
-apache-rat-0.13.jar
+.rat-excludes
Review Comment:
remove the last blank line to make apache-rat happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] codecov-commenter commented on pull request #1175: chore(license): add ignore file/path configs to .rat-excludes
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1175:
URL: https://github.com/apache/incubator-pegasus/pull/1175#issuecomment-1259878104
# [Codecov](https://codecov.io/gh/apache/incubator-pegasus/pull/1175?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@56339c0`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1175 +/- ##
=========================================
Coverage ? 53.40%
=========================================
Files ? 27
Lines ? 2522
Branches ? 0
=========================================
Hits ? 1347
Misses ? 1130
Partials ? 45
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1175: chore(license): add ignore file/path configs to .rat-excludes
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1175:
URL: https://github.com/apache/incubator-pegasus/pull/1175#discussion_r981422804
##########
.rat-excludes:
##########
@@ -1,12 +1,29 @@
-.*json
-.*in
-carrot
-sds/*
-linenoise/*
+.*go.sum
+.*csv
+.*npmigonre
+.*gtest.filter
+FindRT.cmake
+FindDL.cmake
+dsn_err_string.go
+rocskdb_err_string.go
+safe_strerror_posix.h
+autoresetevent.h
+autoreseteventcondvar.h
+benaphore.h
+bitfield.h
+rwlock.h
+sema.h
+copy_source.txt
+suite.*
+nfs_test_file.*
+build_config.h
+command.txt
+safe_strerror_posix.cpp
+autoref_ptr_test.cpp
+config-empty.ini
argh.h
-git_commit.h
-ssh-no-interactive
-scp-no-interactive
+linenoise/*
+sds/*
+.*patch
DISCLAIMER-WIP
-.rat-excludes
-apache-rat-0.13.jar
+.rat-excludes
Review Comment:
Yes, I removed the last blank line to make apache-rat happy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1175: chore(license): add ignore file/path configs to .rat-excludes
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1175:
URL: https://github.com/apache/incubator-pegasus/pull/1175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org