You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/02/17 07:00:18 UTC

Re: Review Request 30974: Updated MockScheduler to pass implicit acknowledgements parameter.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30974/
-----------------------------------------------------------

(Updated Feb. 17, 2015, 6 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

* Updates per the removal of the signature change on the API.


Summary (updated)
-----------------

Updated MockScheduler to pass implicit acknowledgements parameter.


Bugs: MESOS-2347
    https://issues.apache.org/jira/browse/MESOS-2347


Repository: mesos


Description
-------

Updated test expectations for the statusUpdate API change.


Diffs (updated)
-----

  src/tests/mesos.hpp 60c70043c8266a422ffa03ab5a949da0bc822124 
  src/tests/slave_recovery_tests.cpp 8210c52afd03e2a722657c45ef8ed2dae7988022 

Diff: https://reviews.apache.org/r/30974/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 30974: Updated MockScheduler to pass implicit acknowledgements parameter.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30974/#review73207
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 17, 2015, 6 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30974/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 6 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2347
>     https://issues.apache.org/jira/browse/MESOS-2347
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated test expectations for the statusUpdate API change.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 60c70043c8266a422ffa03ab5a949da0bc822124 
>   src/tests/slave_recovery_tests.cpp 8210c52afd03e2a722657c45ef8ed2dae7988022 
> 
> Diff: https://reviews.apache.org/r/30974/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>