You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/11/06 18:29:41 UTC
Review Request 27685: Introduced TASK_ERROR for unrecoverable errors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27685/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-1143
https://issues.apache.org/jira/browse/MESOS-1143
Repository: mesos-git
Description
-------
see summary
Diffs
-----
include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca
src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44
Diff: https://reviews.apache.org/r/27685/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable
errors
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27685/#review61011
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 12, 2014, 6:06 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27685/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2014, 6:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1143
> https://issues.apache.org/jira/browse/MESOS-1143
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca
> src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7
> src/master/master.cpp 0e182a6328e089bcc7e9b173e267f6d5ca357890
> src/tests/master_authorization_tests.cpp aafa72452d2542fe56f8c3dee5cfabd97f16991e
> src/tests/resource_offers_tests.cpp ee332c3a529d77af0d1760fbafad51769bf7dc2c
>
> Diff: https://reviews.apache.org/r/27685/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable
errors
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27685/
-----------------------------------------------------------
(Updated Nov. 12, 2014, 10:06 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
rebased
Bugs: MESOS-1143
https://issues.apache.org/jira/browse/MESOS-1143
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca
src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7
src/master/master.cpp 0e182a6328e089bcc7e9b173e267f6d5ca357890
src/tests/master_authorization_tests.cpp aafa72452d2542fe56f8c3dee5cfabd97f16991e
src/tests/resource_offers_tests.cpp ee332c3a529d77af0d1760fbafad51769bf7dc2c
Diff: https://reviews.apache.org/r/27685/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable
errors
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27685/
-----------------------------------------------------------
(Updated Nov. 7, 2014, 2:04 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
fixed some tests.
Bugs: MESOS-1143
https://issues.apache.org/jira/browse/MESOS-1143
Repository: mesos-git
Description
-------
see summary
Diffs (updated)
-----
include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca
src/master/master.hpp 687f1789712dcd867b411badd85f4a12ae8f16d7
src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44
src/tests/resource_offers_tests.cpp ee332c3a529d77af0d1760fbafad51769bf7dc2c
Diff: https://reviews.apache.org/r/27685/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable
errors
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Nov. 7, 2014, 11:25 a.m., Vinod Kone wrote:
> > NM. Looks like review bot caught this. Did you forget to run 'make check' ?
> >
> > Also, before this lands you should send an email to dev list to solicit feedback. This is a big change.
i ran make check, i had GTEST_FILTER set. sorry.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27685/#review60360
-----------------------------------------------------------
On Nov. 6, 2014, 9:29 a.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27685/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 9:29 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1143
> https://issues.apache.org/jira/browse/MESOS-1143
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44
>
> Diff: https://reviews.apache.org/r/27685/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable
errors
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27685/#review60360
-----------------------------------------------------------
NM. Looks like review bot caught this. Did you forget to run 'make check' ?
Also, before this lands you should send an email to dev list to solicit feedback. This is a big change.
- Vinod Kone
On Nov. 6, 2014, 5:29 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27685/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 5:29 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1143
> https://issues.apache.org/jira/browse/MESOS-1143
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44
>
> Diff: https://reviews.apache.org/r/27685/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable
errors
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27685/#review60358
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/27685/#comment101721>
These should be TASK_ERROR metrics.
src/master/master.cpp
<https://reviews.apache.org/r/27685/#comment101722>
Ditto.
src/tests/master_authorization_tests.cpp
<https://reviews.apache.org/r/27685/#comment101723>
I'm surprised this is the only test you had to fix.
Don't we have tests for invalid tasks that need to be fixed?
- Vinod Kone
On Nov. 6, 2014, 5:29 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27685/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2014, 5:29 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1143
> https://issues.apache.org/jira/browse/MESOS-1143
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 6c846f2a688ae721d2895ce51d5d1e68faef28ca
> src/master/master.cpp a860496d9d75ae4e007d35627d778caf10d08428
> src/tests/master_authorization_tests.cpp 5ae855e59036c6cbcec15db5449620a8e5b2aa44
>
> Diff: https://reviews.apache.org/r/27685/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>