You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2013/06/27 23:00:16 UTC

[jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Use the same check style configuration than in the jclouds main repository and fixed all violations. Hope the Jenkins pull request build will no longer complain.
You can merge this Pull Request by running:

  git pull https://github.com/nacx/jclouds-chef 149-checkstyle

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-chef/pull/6

-- Commit Summary --

  * JCLOUDS-149: Use the jclouds checkstyle configuration

-- File Changes --

    M compute/pom.xml (7)
    M core/src/main/java/org/jclouds/chef/domain/Attribute.java (3)
    M core/src/main/java/org/jclouds/chef/domain/ChecksumStatus.java (3)
    M core/src/main/java/org/jclouds/chef/domain/DatabagItem.java (3)
    M core/src/main/java/org/jclouds/chef/domain/Metadata.java (3)
    M core/src/main/java/org/jclouds/chef/domain/Resource.java (3)
    M core/src/main/java/org/jclouds/chef/domain/Sandbox.java (3)
    M core/src/main/java/org/jclouds/chef/domain/SearchResult.java (3)
    M core/src/main/java/org/jclouds/chef/domain/UploadSandbox.java (3)
    M project/pom.xml (9)
    A project/src/etc/checkstyle.xml (84)
    A project/src/etc/checkstyle_suppressions.xml (27)

-- Patch Links --

https://github.com/jclouds/jclouds-chef/pull/6.patch
https://github.com/jclouds/jclouds-chef/pull/6.diff

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Andrew Phillips <no...@github.com>.

Minor comments aside: looks good to me!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20282556

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Ignasi Barrera <no...@github.com>.

Configured the checkstyle plugin according to https://github.com/jclouds/jclouds/pull/50 to reuse the configuration from the main repo (the PR build may fail the checkstyle until the main repo one is merged and the jclouds-resources snapshot is deployed to the Maven repo).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20250222

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Ignasi Barrera <no...@github.com>.

> @@ -73,13 +73,6 @@
>      </dependency>
>      <dependency>
>        <groupId>org.apache.jclouds</groupId>
> -      <artifactId>jclouds-compute</artifactId>
> -      <version>${jclouds.version}</version>
> -      <type>test-jar</type>
> -      <scope>test</scope>
> -    </dependency>

Just saw the warning in the Maven build and removed it :) I'd prefer not to open a separate issue for such a small change, as it has no side effects.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6/files#r4961966

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Andrew Phillips <no...@github.com>.

> @@ -73,13 +73,6 @@
>      </dependency>
>      <dependency>
>        <groupId>org.apache.jclouds</groupId>
> -      <artifactId>jclouds-compute</artifactId>
> -      <version>${jclouds.version}</version>
> -      <type>test-jar</type>
> -      <scope>test</scope>
> -    </dependency>

I'm guessing this is just "additional cleanup"? Doesn't seem related to this PR. Fine for me to keep it here, just curious where it comes from... ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6/files#r4961900

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-chef #133](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/133/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20154851

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Andrew Phillips <no...@github.com>.

> @@ -73,13 +73,6 @@
>      </dependency>
>      <dependency>
>        <groupId>org.apache.jclouds</groupId>
> -      <artifactId>jclouds-compute</artifactId>
> -      <version>${jclouds.version}</version>
> -      <type>test-jar</type>
> -      <scope>test</scope>
> -    </dependency>

> I'd prefer not to open a separate issue for such a small change

+1

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6/files#r4963393

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Ignasi Barrera <no...@github.com>.

Sure. I was working on that yesterday night (in my timezone :)) and found some issues I discussed in the IRC with Andrews B. and G. I didn't have time to push the branch and send an email to the ML. Will do in a while!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20174422

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Andrew Phillips <no...@github.com>.

> @@ -293,6 +293,22 @@
>            </properties>
>          </configuration>
>        </plugin>
> +      <plugin>
> +        <groupId>org.apache.maven.plugins</groupId>
> +        <artifactId>maven-checkstyle-plugin</artifactId>
> +        <version>2.9.1</version>
> +          <dependencies>
> +            <dependency>
> +              <groupId>org.apache.jclouds</groupId>
> +              <artifactId>jclouds-resources</artifactId>
> +              <version>${jclouds.version}</version>
> +            </dependency>
> +          </dependencies>

[formatting] Indent?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6/files#r4961908

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-chef-pull-requests #7](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/7/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20250265

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-chef-pull-requests #3](https://jclouds.ci.cloudbees.com/job/jclouds-chef-pull-requests/3/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20154903

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Andrew Phillips <no...@github.com>.

> jclouds-chef-pull-requests #3 SUCCESS

Looks happy enough. I'm assuming this one run _after_ the pull request job was modified to include checkstyle again?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20164578

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Ignasi Barrera <no...@github.com>.

Merged after having merged the main repo one.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20356917

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Andrew Phillips <no...@github.com>.

> Merged after having merged the main repo one.

Validated by [subsequent PR job build](https://jclouds.ci.cloudbees.com/view/pull%20requests/job/jclouds-chef-pull-requests/9/)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-21692037

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Ignasi Barrera <no...@github.com>.

Closed #6.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by Andrew Phillips <no...@github.com>.

> jclouds-chef-pull-requests #7 FAILURE

Failure expected (see @nacx's [comment above](https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20250222)) - BuildHive doesn't run checkstyle.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20282026

Re: [jclouds-chef] JCLOUDS-149: Use the jclouds checkstyle configuration (#6)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds-chef #142](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-chef/142/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-chef/pull/6#issuecomment-20250244