You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by pwendell <gi...@git.apache.org> on 2015/04/01 03:05:57 UTC

[GitHub] spark pull request: SPARK-6433 hive tests to import spark-sql test...

Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5119#discussion_r27537871
  
    --- Diff: pom.xml ---
    @@ -1472,6 +1473,25 @@
             <groupId>org.scalatest</groupId>
             <artifactId>scalatest-maven-plugin</artifactId>
           </plugin>
    +      <!-- Build the JARs-->
    --- End diff --
    
    Can this say something more useful? Maybe like:
    
    ```
    <!-- Build test-jar's for all projects, since some projects depend on tests from others -->
    ```
    
    Otherwise it might be hard for someone to understand what is going on here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org