You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/03 20:26:50 UTC
[GitHub] [spark] dbtsai opened a new pull request #27778: [SPARK-31027]
[SQL] Refactor `DataSourceStrategy.scala` to minimize the changes to
support nested predicate pushdown
dbtsai opened a new pull request #27778: [SPARK-31027] [SQL] Refactor `DataSourceStrategy.scala` to minimize the changes to support nested predicate pushdown
URL: https://github.com/apache/spark/pull/27778
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594523740
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594162329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23992/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387509437
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +641,16 @@ object DataSourceStrategy {
}
}
}
+
+/**
+ * Find the column name of an expression that can be pushed down.
+ */
+private[sql] object PushableColumn {
Review comment:
execution package is private. We can remove `private[sql]` completely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594393135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24033/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594385653
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387403991
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
Shall we make it an object with `unapply`, and use it as a pattern match below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594162321
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594270255
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594270255
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594325905
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335198
**[Test build #119278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119278/testReport)** for PR 27778 at commit [`d08f0ed`](https://github.com/apache/spark/commit/d08f0ed1e49c3610597a8bf88e407007eec02cd8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594393121
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387445339
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
Oh, thanks, @dongjoon-hyun. I didn't see your comment before my comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594392473
**[Test build #119293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119293/testReport)** for PR 27778 at commit [`cad92d6`](https://github.com/apache/spark/commit/cad92d60487f5b3ddd6c5aa4ed5fbad74f36c731).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594156000
**[Test build #119251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119251/testReport)** for PR 27778 at commit [`56c56a0`](https://github.com/apache/spark/commit/56c56a0e36fd8e610d9cb525e2cd9f8f08ba99ca).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594294085
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387445266
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
I was thinking the pattern match seems better with less diff and more consistent. There's also one similar example such as https://github.com/apache/spark/blob/0032d85153e34b9ac69598b7dff530094ed0f640/sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala#L194-L203
It might be best to rename `PushDownColName` something like `PushableColumnName` but no strong preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594386339
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594386348
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24028/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387399356
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
##########
@@ -22,68 +22,82 @@ import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.sources
import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.{IntegerType, StringType, StructField, StructType}
class DataSourceStrategySuite extends PlanTest with SharedSparkSession {
+ val attrInts = Seq(
+ 'cint.int
+ ).zip(Seq(
+ "cint"
+ ))
- test("translate simple expression") {
- val attrInt = 'cint.int
- val attrStr = 'cstr.string
+ val attrStrs = Seq(
+ 'cstr.int
Review comment:
`'cstr.string`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594340673
**[Test build #119281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119281/testReport)** for PR 27778 at commit [`09826d1`](https://github.com/apache/spark/commit/09826d1502be444118fe1aad30c43f6ba4f8af58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380223
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119276/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594647549
Thank you all. Looks much better!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387278397
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
##########
@@ -22,68 +22,82 @@ import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.sources
import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.{IntegerType, StringType, StructField, StructType}
class DataSourceStrategySuite extends PlanTest with SharedSparkSession {
+ val attrInts = Seq(
+ 'cint.int,
+ ).zip(Seq(
+ "cint",
+ ))
- test("translate simple expression") {
- val attrInt = 'cint.int
- val attrStr = 'cstr.string
+ val attrStrs = Seq(
+ 'cstr.int,
+ ).zip(Seq(
+ "cstr",
+ ))
+
+ test("translate simple expression") { attrInts.zip(attrStrs)
Review comment:
Indentation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387447770
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
I re-named it to make it cleaner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335106
@HyukjinKwon @dongjoon-hyun @viirya @rdblue @cloud-fan
Some changes based on @HyukjinKwon 's suggestion to use extractor pattern have been done. Would like to have your final reviews. Thanks,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594268424
**[Test build #119252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119252/testReport)** for PR 27778 at commit [`ea2d1f6`](https://github.com/apache/spark/commit/ea2d1f6bbe6e57424097cc3b5c80fe0a6e90afe2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594389074
**[Test build #119290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119290/testReport)** for PR 27778 at commit [`09826d1`](https://github.com/apache/spark/commit/09826d1502be444118fe1aad30c43f6ba4f8af58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594563278
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594323914
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387444597
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
+1 for @HyukjinKwon 's suggestion and the new @dbtsai 's code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594379914
**[Test build #119277 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119277/testReport)** for PR 27778 at commit [`4bd58d3`](https://github.com/apache/spark/commit/4bd58d3e798c957c8fe92ea05801996459517e88).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` case class PushDownColumn(name: String, dataType: DataType)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380195
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594327794
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24017/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594323923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24015/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594291728
**[Test build #119259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119259/testReport)** for PR 27778 at commit [`b3ccd78`](https://github.com/apache/spark/commit/b3ccd784b9b465863597588964b5d192fd465860).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380156
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119281/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594563303
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119293/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594325905
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594379900
**[Test build #119276 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119276/testReport)** for PR 27778 at commit [`89fe568`](https://github.com/apache/spark/commit/89fe568062fc42c06ff0fc21889b0da547826529).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class PushDownCol(name: String, dataType: DataType)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594154950
**[Test build #119251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119251/testReport)** for PR 27778 at commit [`56c56a0`](https://github.com/apache/spark/commit/56c56a0e36fd8e610d9cb525e2cd9f8f08ba99ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594162329
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23992/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380299
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594327794
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24017/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594523760
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119290/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594389074
**[Test build #119290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119290/testReport)** for PR 27778 at commit [`09826d1`](https://github.com/apache/spark/commit/09826d1502be444118fe1aad30c43f6ba4f8af58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594325912
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24016/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594151900
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594327472
**[Test build #119277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119277/testReport)** for PR 27778 at commit [`4bd58d3`](https://github.com/apache/spark/commit/4bd58d3e798c957c8fe92ea05801996459517e88).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335459
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594151910
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23991/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594341056
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24021/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594392473
**[Test build #119293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119293/testReport)** for PR 27778 at commit [`cad92d6`](https://github.com/apache/spark/commit/cad92d60487f5b3ddd6c5aa4ed5fbad74f36c731).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380204
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119278/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335461
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24018/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594393135
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24033/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335198
**[Test build #119278 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119278/testReport)** for PR 27778 at commit [`d08f0ed`](https://github.com/apache/spark/commit/d08f0ed1e49c3610597a8bf88e407007eec02cd8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594193877
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23998/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594523760
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119290/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380137
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387445483
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
+
+/**
+ * Find the column name of an expression that can be pushed down.
+ */
+object PushDownCol {
Review comment:
`PushDownCol` sounds like `Column` instead of name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387466848
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +641,16 @@ object DataSourceStrategy {
}
}
}
+
+/**
+ * Find the column name of an expression that can be pushed down.
+ */
+private[sql] object PushableColumn {
Review comment:
@dbtsai, if this is `private[sql]` for the test purpose, we could just `private[datasources]`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387446016
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
Ur, the last commit is quite different from the above sample code. I'm not sure that last commit is better or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387442798
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
I understand `private[sql]` can scope explicitly which makes sense in a way. However, the current decision was made across the codebase as of SPARK-16964 which also makes sense. What about sticking to one existing way as the current codebase does, and changing it globally later if this is found problematic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594323662
**[Test build #119276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119276/testReport)** for PR 27778 at commit [`89fe568`](https://github.com/apache/spark/commit/89fe568062fc42c06ff0fc21889b0da547826529).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594156019
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380312
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119277/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594294085
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594563303
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119293/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380156
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119281/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594294114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119259/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594341046
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387467415
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -438,60 +438,66 @@ object DataSourceStrategy {
}
private def translateLeafNodeFilter(predicate: Expression): Option[Filter] = predicate match {
- case expressions.EqualTo(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
- case expressions.EqualTo(Literal(v, t), a: Attribute) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
-
- case expressions.EqualNullSafe(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
- case expressions.EqualNullSafe(Literal(v, t), a: Attribute) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThan(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
- case expressions.GreaterThan(Literal(v, t), a: Attribute) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
-
- case expressions.LessThan(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
- case expressions.LessThan(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.GreaterThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.LessThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.LessThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.InSet(a: Attribute, set) =>
- val toScala = CatalystTypeConverters.createToScalaConverter(a.dataType)
- Some(sources.In(a.name, set.toArray.map(toScala)))
+ case expressions.EqualTo(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+ case expressions.EqualTo(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+
+ case expressions.EqualNullSafe(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+ case expressions.EqualNullSafe(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+
+ case expressions.GreaterThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+ case expressions.GreaterThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+
+ case expressions.LessThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+ case expressions.LessThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+
+ case expressions.GreaterThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+ case expressions.GreaterThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.LessThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+ case expressions.LessThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.InSet(e: Expression, set) => e match {
Review comment:
Seems we don't need `: Expression` here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387455194
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
Review comment:
WDYT now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594379903
**[Test build #119278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119278/testReport)** for PR 27778 at commit [`d08f0ed`](https://github.com/apache/spark/commit/d08f0ed1e49c3610597a8bf88e407007eec02cd8).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594323914
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594294114
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119259/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387510058
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -438,60 +438,66 @@ object DataSourceStrategy {
}
private def translateLeafNodeFilter(predicate: Expression): Option[Filter] = predicate match {
- case expressions.EqualTo(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
- case expressions.EqualTo(Literal(v, t), a: Attribute) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
-
- case expressions.EqualNullSafe(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
- case expressions.EqualNullSafe(Literal(v, t), a: Attribute) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThan(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
- case expressions.GreaterThan(Literal(v, t), a: Attribute) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
-
- case expressions.LessThan(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
- case expressions.LessThan(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.GreaterThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.LessThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.LessThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.InSet(a: Attribute, set) =>
- val toScala = CatalystTypeConverters.createToScalaConverter(a.dataType)
- Some(sources.In(a.name, set.toArray.map(toScala)))
+ case expressions.EqualTo(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+ case expressions.EqualTo(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+
+ case expressions.EqualNullSafe(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+ case expressions.EqualNullSafe(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+
+ case expressions.GreaterThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+ case expressions.GreaterThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+
+ case expressions.LessThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+ case expressions.LessThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+
+ case expressions.GreaterThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+ case expressions.GreaterThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.LessThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+ case expressions.LessThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.InSet(e: Expression, set) => e match {
+ case PushableColumn(name) =>
+ val toScala = CatalystTypeConverters.createToScalaConverter(e.dataType)
+ Some(sources.In(name, set.toArray.map(toScala)))
+ case _ => None
+ }
// Because we only convert In to InSet in Optimizer when there are more than certain
// items. So it is possible we still get an In expression here that needs to be pushed
// down.
- case expressions.In(a: Attribute, list) if list.forall(_.isInstanceOf[Literal]) =>
- val hSet = list.map(_.eval(EmptyRow))
- val toScala = CatalystTypeConverters.createToScalaConverter(a.dataType)
- Some(sources.In(a.name, hSet.toArray.map(toScala)))
+ case expressions.In(e, list) => e match {
Review comment:
Nice, +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387429115
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
##########
@@ -22,68 +22,82 @@ import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.sources
import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.{IntegerType, StringType, StructField, StructType}
class DataSourceStrategySuite extends PlanTest with SharedSparkSession {
+ val attrInts = Seq(
+ 'cint.int
+ ).zip(Seq(
+ "cint"
+ ))
- test("translate simple expression") {
- val attrInt = 'cint.int
- val attrStr = 'cstr.string
+ val attrStrs = Seq(
+ 'cstr.int
Review comment:
fixed. thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594386348
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24028/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594325912
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24016/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387447772
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
Review comment:
at https://github.com/apache/spark/blob/0032d85153e34b9ac69598b7dff530094ed0f640/sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala#L245-L248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594156029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119251/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594341056
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24021/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387446236
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
Review comment:
We need it for keeping the `dataType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380212
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387393722
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
`private[sql]` would better be removed [SPARK-16964](https://issues.apache.org/jira/browse/SPARK-16964)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594193444
**[Test build #119259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119259/testReport)** for PR 27778 at commit [`b3ccd78`](https://github.com/apache/spark/commit/b3ccd784b9b465863597588964b5d192fd465860).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594156019
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor `DataSourceStrategy.scala` to minimize the changes to
support nested predicate pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor `DataSourceStrategy.scala` to minimize the changes to support nested predicate pushdown
URL: https://github.com/apache/spark/pull/27778#issuecomment-594151900
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor `DataSourceStrategy.scala` to minimize the changes to
support nested predicate pushdown
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor `DataSourceStrategy.scala` to minimize the changes to support nested predicate pushdown
URL: https://github.com/apache/spark/pull/27778#issuecomment-594151910
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23991/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380195
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594154950
**[Test build #119251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119251/testReport)** for PR 27778 at commit [`56c56a0`](https://github.com/apache/spark/commit/56c56a0e36fd8e610d9cb525e2cd9f8f08ba99ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335461
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24018/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387447685
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
Review comment:
I see. what about doing it as:
```scala
case expressions.Contains(e: Expression, Literal(v: UTF8String, StringType))
if PushDownCol.unapply(e).isDefined =>
e.dataType ...
val Some(name) = PushDownCol.unapply(e) ...
```
I faced similar problem before and worked around as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594688462
Also merged into 3.0 branch since it's just refactoring without introducing new feature. It will make code maintenance easier for 3.0 and future master. Thanks all for reviewing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594523740
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387513017
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +641,16 @@ object DataSourceStrategy {
}
}
}
+
+/**
+ * Find the column name of an expression that can be pushed down.
+ */
+private[sql] object PushableColumn {
Review comment:
Okay. Addressed. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380204
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119278/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594565088
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380223
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119276/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387509040
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -438,60 +438,66 @@ object DataSourceStrategy {
}
private def translateLeafNodeFilter(predicate: Expression): Option[Filter] = predicate match {
- case expressions.EqualTo(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
- case expressions.EqualTo(Literal(v, t), a: Attribute) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
-
- case expressions.EqualNullSafe(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
- case expressions.EqualNullSafe(Literal(v, t), a: Attribute) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThan(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
- case expressions.GreaterThan(Literal(v, t), a: Attribute) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
-
- case expressions.LessThan(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
- case expressions.LessThan(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.GreaterThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.LessThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.LessThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.InSet(a: Attribute, set) =>
- val toScala = CatalystTypeConverters.createToScalaConverter(a.dataType)
- Some(sources.In(a.name, set.toArray.map(toScala)))
+ case expressions.EqualTo(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+ case expressions.EqualTo(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+
+ case expressions.EqualNullSafe(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+ case expressions.EqualNullSafe(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+
+ case expressions.GreaterThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+ case expressions.GreaterThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+
+ case expressions.LessThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+ case expressions.LessThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+
+ case expressions.GreaterThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+ case expressions.GreaterThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.LessThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+ case expressions.LessThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.InSet(e: Expression, set) => e match {
+ case PushableColumn(name) =>
+ val toScala = CatalystTypeConverters.createToScalaConverter(e.dataType)
+ Some(sources.In(name, set.toArray.map(toScala)))
+ case _ => None
+ }
// Because we only convert In to InSet in Optimizer when there are more than certain
// items. So it is possible we still get an In expression here that needs to be pushed
// down.
- case expressions.In(a: Attribute, list) if list.forall(_.isInstanceOf[Literal]) =>
- val hSet = list.map(_.eval(EmptyRow))
- val toScala = CatalystTypeConverters.createToScalaConverter(a.dataType)
- Some(sources.In(a.name, hSet.toArray.map(toScala)))
+ case expressions.In(e, list) => e match {
Review comment:
why not just
```
case expressions.In(e @ PushableColumn(name), list) if list.forall(_.isInstanceOf[Literal]) =>
val hSet = list.map(_.eval(EmptyRow))
val toScala = CatalystTypeConverters.createToScalaConverter(e.dataType)
Some(sources.In(name, hSet.toArray.map(toScala)))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594270258
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119252/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387434600
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
With
```scala
object PushDownColName {
def unapply(e: Expression): Option[String] = {
def helper(e: Expression) = e match {
case a: Attribute => Some(a.name)
case _ => None
}
helper(e)
}
}
```
The following code can be written
```scala
case expressions.EqualTo(PushDownColName(name), Literal(v, t)) =>
Some(sources.EqualTo(name, convertToScala(v, t)))
```
instead of
```scala
case expressions.EqualTo(e: Expression, Literal(v, t)) =>
pushDownColName(e).map(sources.EqualTo(_, convertToScala(v, t)))
```
I don't have strong preference about it. What do others feel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594193871
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594323662
**[Test build #119276 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119276/testReport)** for PR 27778 at commit [`89fe568`](https://github.com/apache/spark/commit/89fe568062fc42c06ff0fc21889b0da547826529).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594270258
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119252/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387425192
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
Since it's not an instance that will be used somewhere else, and mainly for internal usage, I would like to tighten the visibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594393121
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387278397
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategySuite.scala
##########
@@ -22,68 +22,82 @@ import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.plans.PlanTest
import org.apache.spark.sql.sources
import org.apache.spark.sql.test.SharedSparkSession
+import org.apache.spark.sql.types.{IntegerType, StringType, StructField, StructType}
class DataSourceStrategySuite extends PlanTest with SharedSparkSession {
+ val attrInts = Seq(
+ 'cint.int,
+ ).zip(Seq(
+ "cint",
+ ))
- test("translate simple expression") {
- val attrInt = 'cint.int
- val attrStr = 'cstr.string
+ val attrStrs = Seq(
+ 'cstr.int,
+ ).zip(Seq(
+ "cstr",
+ ))
+
+ test("translate simple expression") { attrInts.zip(attrStrs)
Review comment:
~Indentation?~ Never mind.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380299
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594340673
**[Test build #119281 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119281/testReport)** for PR 27778 at commit [`09826d1`](https://github.com/apache/spark/commit/09826d1502be444118fe1aad30c43f6ba4f8af58).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387294541
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,72 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
+ def helper(e: Expression): Option[Seq[String]] = e match {
+ case a: Attribute => Some(Seq(a.name))
+ case _ => None
+ }
+ helper(e).flatMap(_.headOption)
Review comment:
Although I know the background, shall we write like the following simpler way in this PR?
```scala
def helper(e: Expression): Option[String] = e match {
case a: Attribute => Some(a.name)
case _ => None
}
helper(e)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594193871
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594379902
**[Test build #119281 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119281/testReport)** for PR 27778 at commit [`09826d1`](https://github.com/apache/spark/commit/09826d1502be444118fe1aad30c43f6ba4f8af58).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594193444
**[Test build #119259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119259/testReport)** for PR 27778 at commit [`b3ccd78`](https://github.com/apache/spark/commit/b3ccd784b9b465863597588964b5d192fd465860).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380137
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594386339
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594327792
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594193877
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23998/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594161759
**[Test build #119252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119252/testReport)** for PR 27778 at commit [`ea2d1f6`](https://github.com/apache/spark/commit/ea2d1f6bbe6e57424097cc3b5c80fe0a6e90afe2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380312
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119277/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594335459
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387444902
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -437,61 +437,76 @@ object DataSourceStrategy {
}
}
+ /**
+ * Find the column name of an expression that can be pushed down.
+ */
+ private[sql] def pushDownColName(e: Expression): Option[String] = {
Review comment:
+1 for removal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387445780
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
Review comment:
Ur, do we need to have a new case class for this?
@HyukjinKwon . Is this aligned with your recommendation? This seems to add a new complexity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594380212
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594327792
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594341046
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594323923
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24015/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594561266
**[Test build #119293 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119293/testReport)** for PR 27778 at commit [`cad92d6`](https://github.com/apache/spark/commit/cad92d60487f5b3ddd6c5aa4ed5fbad74f36c731).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387514479
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -438,60 +438,66 @@ object DataSourceStrategy {
}
private def translateLeafNodeFilter(predicate: Expression): Option[Filter] = predicate match {
- case expressions.EqualTo(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
- case expressions.EqualTo(Literal(v, t), a: Attribute) =>
- Some(sources.EqualTo(a.name, convertToScala(v, t)))
-
- case expressions.EqualNullSafe(a: Attribute, Literal(v, t)) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
- case expressions.EqualNullSafe(Literal(v, t), a: Attribute) =>
- Some(sources.EqualNullSafe(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThan(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
- case expressions.GreaterThan(Literal(v, t), a: Attribute) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
-
- case expressions.LessThan(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThan(a.name, convertToScala(v, t)))
- case expressions.LessThan(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThan(a.name, convertToScala(v, t)))
-
- case expressions.GreaterThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.GreaterThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.LessThanOrEqual(a: Attribute, Literal(v, t)) =>
- Some(sources.LessThanOrEqual(a.name, convertToScala(v, t)))
- case expressions.LessThanOrEqual(Literal(v, t), a: Attribute) =>
- Some(sources.GreaterThanOrEqual(a.name, convertToScala(v, t)))
-
- case expressions.InSet(a: Attribute, set) =>
- val toScala = CatalystTypeConverters.createToScalaConverter(a.dataType)
- Some(sources.In(a.name, set.toArray.map(toScala)))
+ case expressions.EqualTo(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+ case expressions.EqualTo(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualTo(name, convertToScala(v, t)))
+
+ case expressions.EqualNullSafe(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+ case expressions.EqualNullSafe(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.EqualNullSafe(name, convertToScala(v, t)))
+
+ case expressions.GreaterThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+ case expressions.GreaterThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+
+ case expressions.LessThan(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThan(name, convertToScala(v, t)))
+ case expressions.LessThan(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThan(name, convertToScala(v, t)))
+
+ case expressions.GreaterThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+ case expressions.GreaterThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.LessThanOrEqual(PushableColumn(name), Literal(v, t)) =>
+ Some(sources.LessThanOrEqual(name, convertToScala(v, t)))
+ case expressions.LessThanOrEqual(Literal(v, t), PushableColumn(name)) =>
+ Some(sources.GreaterThanOrEqual(name, convertToScala(v, t)))
+
+ case expressions.InSet(e: Expression, set) => e match {
+ case PushableColumn(name) =>
+ val toScala = CatalystTypeConverters.createToScalaConverter(e.dataType)
+ Some(sources.In(name, set.toArray.map(toScala)))
+ case _ => None
+ }
// Because we only convert In to InSet in Optimizer when there are more than certain
// items. So it is possible we still get an In expression here that needs to be pushed
// down.
- case expressions.In(a: Attribute, list) if list.forall(_.isInstanceOf[Literal]) =>
- val hSet = list.map(_.eval(EmptyRow))
- val toScala = CatalystTypeConverters.createToScalaConverter(a.dataType)
- Some(sources.In(a.name, hSet.toArray.map(toScala)))
+ case expressions.In(e, list) => e match {
Review comment:
This looks nice. Thanks for the tip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594327472
**[Test build #119277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119277/testReport)** for PR 27778 at commit [`4bd58d3`](https://github.com/apache/spark/commit/4bd58d3e798c957c8fe92ea05801996459517e88).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594522551
**[Test build #119290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119290/testReport)** for PR 27778 at commit [`09826d1`](https://github.com/apache/spark/commit/09826d1502be444118fe1aad30c43f6ba4f8af58).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594161759
**[Test build #119252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119252/testReport)** for PR 27778 at commit [`ea2d1f6`](https://github.com/apache/spark/commit/ea2d1f6bbe6e57424097cc3b5c80fe0a6e90afe2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594162321
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594563278
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27778: [SPARK-31027]
[SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594156029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119251/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27778:
[SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#discussion_r387447685
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -635,3 +636,18 @@ object DataSourceStrategy {
}
}
}
+
+case class PushDownCol(name: String, dataType: DataType)
Review comment:
I see. what about doing it as:
```scala
case expressions.Contains(e: Expression, Literal(v: UTF8String, StringType))
if PushDownCol.unapply(name).isDefined =>
e.dataType ...
name ...
```
I faced similar problem before and worked around as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on issue #27778: [SPARK-31027] [SQL]
Refactor DataSourceStrategy to be more extendable
Posted by GitBox <gi...@apache.org>.
dbtsai commented on issue #27778: [SPARK-31027] [SQL] Refactor DataSourceStrategy to be more extendable
URL: https://github.com/apache/spark/pull/27778#issuecomment-594153195
cc @dongjoon-hyun @gengliangwang @cloud-fan @rdblue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org