You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/21 21:40:48 UTC

[GitHub] [airflow] VladaZakharova commented on a diff in pull request #28230: Add deferrable mode to Kubernetes and GKE operators

VladaZakharova commented on code in PR #28230:
URL: https://github.com/apache/airflow/pull/28230#discussion_r1054858418


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -484,15 +496,21 @@ def extract_xcom(self, pod: k8s.V1Pod):
             return json.loads(result)
 
     def execute(self, context: Context):
-        remote_pod = None
+        """Based on the deferrable parameter runs the pod asynchronously or synchronously"""
+        if self.deferrable:
+            self.asynchronously(context)
+        else:
+            return self.synchronously(context)

Review Comment:
   We have also implemented some features that were and still are very urgent for our costumer. That is why it was important to reach you and your team earlier, to discuss these changes. So, may be after our current PR will be merged you can rebase and add additional logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org