You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ryan Sonnek (JIRA)" <ji...@apache.org> on 2008/03/10 18:05:46 UTC

[jira] Created: (WICKET-1408) ComponentFeedbackMessageFilter should use equals() method to determine equality

ComponentFeedbackMessageFilter should use equals() method to determine equality
-------------------------------------------------------------------------------

                 Key: WICKET-1408
                 URL: https://issues.apache.org/jira/browse/WICKET-1408
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.1
            Reporter: Ryan Sonnek
            Priority: Trivial


http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/feedback/ComponentFeedbackMessageFilter.java?revision=584925&view=markup

This is pretty trivial, but I think the ComponentFeedbackMessageFilter should use the the conventional .equals() method instead of "==" to determine object equality.

feel free to close this issue if there's a reason to be comparing object references instead of values:
http://www.leepoint.net/notes-java/data/expressions/22compareobjects.html




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-1408) ComponentFeedbackMessageFilter should use equals() method to determine equality

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1408.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.3
         Assignee: Igor Vaynberg

i changed it in code, but effectively it is still the same because component does not implement equals, nor should it really. we are working within a hierarchy and the only criteria for components is instance equality.

> ComponentFeedbackMessageFilter should use equals() method to determine equality
> -------------------------------------------------------------------------------
>
>                 Key: WICKET-1408
>                 URL: https://issues.apache.org/jira/browse/WICKET-1408
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.1
>            Reporter: Ryan Sonnek
>            Assignee: Igor Vaynberg
>            Priority: Trivial
>             Fix For: 1.3.3
>
>
> http://svn.apache.org/viewvc/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/feedback/ComponentFeedbackMessageFilter.java?revision=584925&view=markup
> This is pretty trivial, but I think the ComponentFeedbackMessageFilter should use the the conventional .equals() method instead of "==" to determine object equality.
> feel free to close this issue if there's a reason to be comparing object references instead of values:
> http://www.leepoint.net/notes-java/data/expressions/22compareobjects.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.