You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2016/09/13 19:36:26 UTC
[GitHub] trafficserver pull request #1013: TS-4856: Default SSL context fails to load...
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/1013
TS-4856: Default SSL context fails to load.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4856
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1013.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1013
----
commit cc95680ec91f641db9ff21e2aecc9bbb75e0ee5c
Author: Susan Hinrichs <sh...@ieee.org>
Date: 2016-09-13T19:32:36Z
TS-4856: Default SSL context fails to load.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1013: TS-4856: Default SSL context fails to load...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1013#discussion_r78638850
--- Diff: iocore/net/SSLUtils.cc ---
@@ -1629,7 +1629,8 @@ SSLInitServerContext(const SSLConfigParams *params, const ssl_user_config *sslMu
}
if (!sslMultCertSettings->cert) {
- if (sslMultCertSettings->opt != SSLCertContext::OPT_TUNNEL) {
+ // There must be a certificate specified unless the tunnel action is set, or this is the default case
+ if (sslMultCertSettings->opt != SSLCertContext::OPT_TUNNEL && strcmp(sslMultCertSettings->addr, "*") != 0) {
--- End diff --
In this case could "*" be the default destination configured by the operator? Is that required to have a certificate?
Maybe this validation should be done after parsing a config file entry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1013: TS-4856: Default SSL context fails to load.
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1013
Took @jpeach's suggestion and pulled back a bit. Moved the missing cert check out of SSLInitServerContext and made the check at the one call site that actually parses the ssl multicert.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1013: TS-4856: Default SSL context fails to load.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1013
\U0001f44d This looks pretty reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1013: TS-4856: Default SSL context fails to load...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/1013
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1013: TS-4856: Default SSL context fails to load.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1013
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/691/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1013: TS-4856: Default SSL context fails to load.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1013
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/698/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1013: TS-4856: Default SSL context fails to load.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1013
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/803/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1013: TS-4856: Default SSL context fails to load.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1013
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/795/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---