You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/06/06 05:39:28 UTC
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41473: [SPARK-43977][CONNECT] Fix unexpected check result of `dev/connect-jvm-client-mima-check`
dongjoon-hyun commented on code in PR #41473:
URL: https://github.com/apache/spark/pull/41473#discussion_r1218941006
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##########
@@ -95,7 +95,7 @@ object CheckConnectJvmClientCompatibility {
} catch {
case e: Throwable =>
println(e.getMessage)
- resultWriter.write(s"ERROR: ${e.getMessage}")
+ resultWriter.write(s"ERROR: ${e.getMessage}\n")
Review Comment:
This code seems to exist from Apache Spark 3.4.0 but SPARK-43977 is filed for 3.5.0 only. Do we need to backport this?
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/CheckConnectJvmClientCompatibility.scala:
##########
@@ -95,7 +95,7 @@ object CheckConnectJvmClientCompatibility {
} catch {
case e: Throwable =>
println(e.getMessage)
- resultWriter.write(s"ERROR: ${e.getMessage}")
+ resultWriter.write(s"ERROR: ${e.getMessage}\n")
Review Comment:
The old code seems to exist from Apache Spark 3.4.0 but SPARK-43977 is filed for 3.5.0 only. Do we need to backport this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org