You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2017/11/29 17:06:10 UTC
Review Request 64167: Update LDAP sync process to work with improved
user management facility
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64167/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, and Robert Nettleton.
Bugs: AMBARI-21222
https://issues.apache.org/jira/browse/AMBARI-21222
Repository: ambari
Description
-------
Update LDAP sync process to work with improved user management facility
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 816767e703
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java 13c17f9778
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java bba8cf2ad2
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ec0564110c
ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java c3451dd084
ambari-server/src/main/java/org/apache/ambari/server/security/ldap/LdapBatchDto.java 0f9089a342
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java 34bbe9782e
Diff: https://reviews.apache.org/r/64167/diff/1/
Testing
-------
Manually tested
# Local test results:
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 26:45 min
[INFO] Finished at: 2017-11-29T11:41:32-05:00
[INFO] Final Memory: 98M/1962M
[INFO] ------------------------------------------------------------------------
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 64167: Update LDAP sync process to work with
improved user management facility
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64167/#review192138
-----------------------------------------------------------
Ship it!
No more strings! :)
- Jonathan Hurley
On Nov. 29, 2017, 12:06 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64167/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 12:06 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, and Robert Nettleton.
>
>
> Bugs: AMBARI-21222
> https://issues.apache.org/jira/browse/AMBARI-21222
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update LDAP sync process to work with improved user management facility
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 816767e703
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java 13c17f9778
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java bba8cf2ad2
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ec0564110c
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java c3451dd084
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/LdapBatchDto.java 0f9089a342
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java 34bbe9782e
>
>
> Diff: https://reviews.apache.org/r/64167/diff/1/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> ```
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:45 min
> [INFO] Finished at: 2017-11-29T11:41:32-05:00
> [INFO] Final Memory: 98M/1962M
> [INFO] ------------------------------------------------------------------------
> ```
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 64167: Update LDAP sync process to work with
improved user management facility
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64167/#review192139
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Nov. 29, 2017, 5:06 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64167/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 5:06 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene Chekanskiy, Jonathan Hurley, Nate Cole, and Robert Nettleton.
>
>
> Bugs: AMBARI-21222
> https://issues.apache.org/jira/browse/AMBARI-21222
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update LDAP sync process to work with improved user management facility
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java 816767e703
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UserAuthenticationDAO.java 13c17f9778
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UserAuthenticationEntity.java bba8cf2ad2
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java ec0564110c
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java c3451dd084
> ambari-server/src/main/java/org/apache/ambari/server/security/ldap/LdapBatchDto.java 0f9089a342
> ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java 34bbe9782e
>
>
> Diff: https://reviews.apache.org/r/64167/diff/1/
>
>
> Testing
> -------
>
> Manually tested
>
> # Local test results:
> ```
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 26:45 min
> [INFO] Finished at: 2017-11-29T11:41:32-05:00
> [INFO] Final Memory: 98M/1962M
> [INFO] ------------------------------------------------------------------------
> ```
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>