You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2015/03/25 10:34:10 UTC
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/481
STORM-724 [storm-redis] Document RedisStoreBolt and RedisLookupBolt which is missed
I've missed it from STORM-691, sorry!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-724
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/481.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #481
----
commit 286c52bbaea9c83d964ceacac1b44d5815294d3e
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-03-25T09:30:52Z
Remove unused code
commit 4b9b9767c2bcc9b10a541d950a81827d89b4607e
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2015-03-25T09:31:03Z
[storm-redis] Include explanation of basic bolts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/481#issuecomment-87547258
@harshach Thanks for reviewing. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/481#issuecomment-87538359
@harshach It became unused from #451 but I missed to remove it. ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by dashengju <gi...@git.apache.org>.
Github user dashengju commented on the pull request:
https://github.com/apache/storm/pull/481#issuecomment-86294019
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/481#issuecomment-86543353
@dashengju Basic Bolts are planned to release 0.11.0. You can find it from CHANGES.md.
But we can also discuss it to include Basic Bolts to 0.10.0, and actually I'd like to.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/481#issuecomment-87540010
@HeartSaVioR Thanks for the details. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/481#issuecomment-87537114
@HeartSaVioR it looks like PR removed code from a test topology any reason for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-724 [storm-redis] Document RedisStoreBol...
Posted by dashengju <gi...@git.apache.org>.
Github user dashengju commented on the pull request:
https://github.com/apache/storm/pull/481#issuecomment-86542208
@revans2 I think we should merge this PR to all branches. please help to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---