[GitHub] [incubator-superset] villebro commented on a change in pull request #9107: feat: add rolling window support to 'Big Number with Trendline' viz

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #9107: feat: add rolling window support to 'Big Number with Trendline' viz
URL: https://github.com/apache/incubator-superset/pull/9107#discussion_r389347376
 
 

 ##########
 File path: superset/examples/world_bank.py
 ##########
 @@ -97,31 +97,32 @@ def load_world_bank_health_n_pop(
     db.session.commit()
     tbl.fetch_metadata()
 
+    metric = "sum__SP_POP_TOTL"
+    metrics = ["sum__SP_POP_TOTL"]
+    secondary_metric = {
+        "aggregate": "SUM",
+        "column": {
+            "column_name": "SP_RUR_TOTL",
+            "optionName": "_col_SP_RUR_TOTL",
+            "type": "DOUBLE",
+        },
+        "expressionType": "SIMPLE",
+        "hasCustomLabel": True,
+        "label": "Rural Population",
+    }
 
 Review comment:
   For readability later on in the code, calling this `rural_population_metric` or similar would be preferable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org