You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "mike-jumper (via GitHub)" <gi...@apache.org> on 2023/05/08 23:26:29 UTC
[GitHub] [guacamole-server] mike-jumper opened a new pull request, #435: GUACAMOLE-1784: Migrate usage of guac_rdp_audio_buffer_ack() to guac_client_for_user().
mike-jumper opened a new pull request, #435:
URL: https://github.com/apache/guacamole-server/pull/435
The function `guac_rdp_audio_buffer_ack()` is the only location in guacamole-server where a `guac_user` instance is accessed outside the context of a user-specific callback, a no-no in the libguac API. This change migrates that function such that it _is_ a callback, invoked by `guac_client_for_user()` (the function provided by libguac for exactly this purpose).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] jmuehlner merged pull request #435: GUACAMOLE-1784: Migrate usage of guac_rdp_audio_buffer_ack() to guac_client_for_user().
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner merged PR #435:
URL: https://github.com/apache/guacamole-server/pull/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] jmuehlner commented on a diff in pull request #435: GUACAMOLE-1784: Migrate usage of guac_rdp_audio_buffer_ack() to guac_client_for_user().
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #435:
URL: https://github.com/apache/guacamole-server/pull/435#discussion_r1188020269
##########
src/protocols/rdp/channels/audio-input/audio-buffer.c:
##########
@@ -274,6 +274,34 @@ guac_rdp_audio_buffer* guac_rdp_audio_buffer_alloc(guac_client* client) {
return buffer;
}
+/**
+ * Parameters describing an "ack" instruction to be sent to the current user of
+ * an inbound audio stream (guac_rdp_audio_buffer).
+ */
+typedef struct guac_rdp_audio_buffer_ack_params {
+
+ /**
+ * The audio buffer associated with the guac_stream for which the "ack"
+ * instruction should be sent, if any. If there is no associated
+ * guac_stream, this function has no effect.
Review Comment:
Which function has no effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] mike-jumper commented on a diff in pull request #435: GUACAMOLE-1784: Migrate usage of guac_rdp_audio_buffer_ack() to guac_client_for_user().
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on code in PR #435:
URL: https://github.com/apache/guacamole-server/pull/435#discussion_r1188248481
##########
src/protocols/rdp/channels/audio-input/audio-buffer.c:
##########
@@ -274,6 +274,34 @@ guac_rdp_audio_buffer* guac_rdp_audio_buffer_alloc(guac_client* client) {
return buffer;
}
+/**
+ * Parameters describing an "ack" instruction to be sent to the current user of
+ * an inbound audio stream (guac_rdp_audio_buffer).
+ */
+typedef struct guac_rdp_audio_buffer_ack_params {
+
+ /**
+ * The audio buffer associated with the guac_stream for which the "ack"
+ * instruction should be sent, if any. If there is no associated
+ * guac_stream, this function has no effect.
Review Comment:
Ah, I'll fix that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org