You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ilya Shishkov (Jira)" <ji...@apache.org> on 2024/08/13 16:51:00 UTC
[jira] [Commented] (IGNITE-22920) Final cleanup GridDhtTxFinishRequest
[ https://issues.apache.org/jira/browse/IGNITE-22920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873259#comment-17873259 ]
Ilya Shishkov commented on IGNITE-22920:
----------------------------------------
{{GridDhtLockResponse#nearEvicted()}} usage was removed in IGNITE-10078 [1]. Thus, this method seems to be useless.
# https://github.com/apache/ignite/commit/e7a90a445f09b0783918a0b5cfbeddee7102c45e#diff-0b00deac783b25444a9201a862ba487bb1f83de7dd319edd2b02064b8efebbeaL1426
> Final cleanup GridDhtTxFinishRequest
> ------------------------------------
>
> Key: IGNITE-22920
> URL: https://issues.apache.org/jira/browse/IGNITE-22920
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ilya Shishkov
> Assignee: Ilya Shishkov
> Priority: Minor
> Labels: ise
>
> {{GridDhtTxFinishRequest}} has two redundant class members:
> # {{GridDhtTxFinishRequest#pendingVers}} field does not have getter and any other external read possibility.
> # {{GridDhtTxFinishRequest#partUpdateCounters()}} getter has no usages, moreover corresponding field {{#partUpdateCnt}} can not be updated: there are no constructor parameters or setter method.
> We have to figure out whether this is redundant code or whether we have *_lost some useful functionality_*.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)