You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2012/11/06 05:41:59 UTC
Re: Review Request: Refactored Allocator
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7720/
-----------------------------------------------------------
(Updated Nov. 6, 2012, 4:41 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Fixed MockAllocatorProcess to dispatch to the underlying allocator process.
Description
-------
Refactored Allocator
Diffs (updated)
-----
src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798
src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac
src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831
src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4
src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d
src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5
src/master/hierarchical_allocator_process.hpp 266d339bdb72f8c63288d91c1f514da07ee9acf2
src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193
src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469
src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d
src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d
src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536
src/tests/allocator_tests.cpp b0056b983b3a604e9124306cb12a366e5896a588
src/tests/allocator_zookeeper_tests.cpp 72ec292cf5a85d2012d940a347293ef105206ef1
src/tests/fault_tolerance_tests.cpp a01d1aef012b636f2ced64d4d2ffabfb6ce42644
src/tests/gc_tests.cpp b61b2de621e227f327ce546b62f8dfc528f3894e
src/tests/master_detector_tests.cpp c0dc301f2a9f8d586864794c0526caac6c68727e
src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3
src/tests/resource_offers_tests.cpp 9f7916873423382443f39c31b1d682dc0e4071bb
src/tests/utils.hpp e0036c04bef60d62cc4314a7e0beb02a0071a808
Diff: https://reviews.apache.org/r/7720/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Refactored Allocator
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7720/#review13159
-----------------------------------------------------------
src/master/allocator.hpp
<https://reviews.apache.org/r/7720/#comment28314>
Kill.
src/master/allocator.hpp
<https://reviews.apache.org/r/7720/#comment28315>
Kill.
- Benjamin Hindman
On Nov. 6, 2012, 4:41 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7720/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 4:41 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Refactored Allocator
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798
> src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac
> src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831
> src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4
> src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d
> src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5
> src/master/hierarchical_allocator_process.hpp 266d339bdb72f8c63288d91c1f514da07ee9acf2
> src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193
> src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469
> src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d
> src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d
> src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536
> src/tests/allocator_tests.cpp b0056b983b3a604e9124306cb12a366e5896a588
> src/tests/allocator_zookeeper_tests.cpp 72ec292cf5a85d2012d940a347293ef105206ef1
> src/tests/fault_tolerance_tests.cpp a01d1aef012b636f2ced64d4d2ffabfb6ce42644
> src/tests/gc_tests.cpp b61b2de621e227f327ce546b62f8dfc528f3894e
> src/tests/master_detector_tests.cpp c0dc301f2a9f8d586864794c0526caac6c68727e
> src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3
> src/tests/resource_offers_tests.cpp 9f7916873423382443f39c31b1d682dc0e4071bb
> src/tests/utils.hpp e0036c04bef60d62cc4314a7e0beb02a0071a808
>
> Diff: https://reviews.apache.org/r/7720/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Refactored Allocator
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7720/#review13233
-----------------------------------------------------------
Ship it!
src/master/allocator.hpp
<https://reviews.apache.org/r/7720/#comment28464>
s/return //
src/sched/sched.cpp
<https://reviews.apache.org/r/7720/#comment28462>
s/the//
src/sched/sched.cpp
<https://reviews.apache.org/r/7720/#comment28463>
Ditto.
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/7720/#comment28461>
Kill.
src/tests/allocator_zookeeper_tests.cpp
<https://reviews.apache.org/r/7720/#comment28460>
Kill this.
src/tests/utils.hpp
<https://reviews.apache.org/r/7720/#comment28466>
It's probably time to split this out from utils.hpp, this file has too much stuff in it.
- Benjamin Hindman
On Nov. 6, 2012, 8:10 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7720/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 8:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Refactored Allocator.
>
> Features:
>
> --> Master can make direct method calls on the Allocator instead of doing dipatches.
>
> --> MockAllocatorProcess does dispatches to the underlying allocator process instead of directly invoking the methods.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798
> src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac
> src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831
> src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4
> src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d
> src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5
> src/master/hierarchical_allocator_process.hpp 266d339bdb72f8c63288d91c1f514da07ee9acf2
> src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193
> src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469
> src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d
> src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d
> src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536
> src/tests/allocator_tests.cpp b0056b983b3a604e9124306cb12a366e5896a588
> src/tests/allocator_zookeeper_tests.cpp 72ec292cf5a85d2012d940a347293ef105206ef1
> src/tests/fault_tolerance_tests.cpp a01d1aef012b636f2ced64d4d2ffabfb6ce42644
> src/tests/gc_tests.cpp b61b2de621e227f327ce546b62f8dfc528f3894e
> src/tests/master_detector_tests.cpp c0dc301f2a9f8d586864794c0526caac6c68727e
> src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3
> src/tests/resource_offers_tests.cpp 9f7916873423382443f39c31b1d682dc0e4071bb
> src/tests/utils.hpp e0036c04bef60d62cc4314a7e0beb02a0071a808
>
> Diff: https://reviews.apache.org/r/7720/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Refactored Allocator
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7720/#review13202
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Nov. 6, 2012, 8:10 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7720/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2012, 8:10 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> Refactored Allocator.
>
> Features:
>
> --> Master can make direct method calls on the Allocator instead of doing dipatches.
>
> --> MockAllocatorProcess does dispatches to the underlying allocator process instead of directly invoking the methods.
>
>
> Diffs
> -----
>
> src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
> src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798
> src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac
> src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831
> src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4
> src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d
> src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5
> src/master/hierarchical_allocator_process.hpp 266d339bdb72f8c63288d91c1f514da07ee9acf2
> src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193
> src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469
> src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d
> src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d
> src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536
> src/tests/allocator_tests.cpp b0056b983b3a604e9124306cb12a366e5896a588
> src/tests/allocator_zookeeper_tests.cpp 72ec292cf5a85d2012d940a347293ef105206ef1
> src/tests/fault_tolerance_tests.cpp a01d1aef012b636f2ced64d4d2ffabfb6ce42644
> src/tests/gc_tests.cpp b61b2de621e227f327ce546b62f8dfc528f3894e
> src/tests/master_detector_tests.cpp c0dc301f2a9f8d586864794c0526caac6c68727e
> src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3
> src/tests/resource_offers_tests.cpp 9f7916873423382443f39c31b1d682dc0e4071bb
> src/tests/utils.hpp e0036c04bef60d62cc4314a7e0beb02a0071a808
>
> Diff: https://reviews.apache.org/r/7720/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Refactored Allocator
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7720/
-----------------------------------------------------------
(Updated Nov. 6, 2012, 8:10 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
posting the proper diff.
please look at the diff between diffs 6-8 to see the changes.
Description
-------
Refactored Allocator.
Features:
--> Master can make direct method calls on the Allocator instead of doing dipatches.
--> MockAllocatorProcess does dispatches to the underlying allocator process instead of directly invoking the methods.
Diffs (updated)
-----
src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798
src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac
src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831
src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4
src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d
src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5
src/master/hierarchical_allocator_process.hpp 266d339bdb72f8c63288d91c1f514da07ee9acf2
src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193
src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469
src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d
src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d
src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536
src/tests/allocator_tests.cpp b0056b983b3a604e9124306cb12a366e5896a588
src/tests/allocator_zookeeper_tests.cpp 72ec292cf5a85d2012d940a347293ef105206ef1
src/tests/fault_tolerance_tests.cpp a01d1aef012b636f2ced64d4d2ffabfb6ce42644
src/tests/gc_tests.cpp b61b2de621e227f327ce546b62f8dfc528f3894e
src/tests/master_detector_tests.cpp c0dc301f2a9f8d586864794c0526caac6c68727e
src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3
src/tests/resource_offers_tests.cpp 9f7916873423382443f39c31b1d682dc0e4071bb
src/tests/utils.hpp e0036c04bef60d62cc4314a7e0beb02a0071a808
Diff: https://reviews.apache.org/r/7720/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Refactored Allocator
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7720/
-----------------------------------------------------------
(Updated Nov. 6, 2012, 8:08 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
Reverted Allocator methods to return void.
Formatting.
Description (updated)
-------
Refactored Allocator.
Features:
--> Master can make direct method calls on the Allocator instead of doing dipatches.
--> MockAllocatorProcess does dispatches to the underlying allocator process instead of directly invoking the methods.
Diffs (updated)
-----
Makefile.am cf287fc129fe17ebf31812026d0b8f08067fb2bf
src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f
src/detector/detector.hpp d859b080b99e23d511458a27272db33c5486bb4b
src/detector/detector.cpp 62df8bdf539eb13b2a6dc00eb2f6a07381d59106
src/examples/balloon_executor.cpp 9f3783b24427d3102c89b1c843fc70c842156395
src/linux/cgroups.hpp 8147919bf7f17e50e047f813db58f99fb9dfffe5
src/linux/cgroups.cpp a6056c31d504f5570872c0ed123b28400640d5cf
src/linux/proc.hpp dd0b30ca07c7bfb89d008f9b7a4441491fbae7fd
src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798
src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac
src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831
src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4
src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d
src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5
src/master/hierarchical_allocator_process.hpp 266d339bdb72f8c63288d91c1f514da07ee9acf2
src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193
src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469
src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d
src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d
src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536
src/slave/cgroups_isolation_module.hpp 76d916f8882b4e116327ed3249b01d439b5b89d5
src/slave/cgroups_isolation_module.cpp a43d31760f14e641cc7d75b6e98041f98bba2b63
src/slave/process_based_isolation_module.cpp 744832625d6d1898eb2b31b184f5d0c68408835d
src/slave/slave.cpp 0321bc516166aacfd261c48f1f4293622d18ae0e
src/tests/allocator_tests.cpp b0056b983b3a604e9124306cb12a366e5896a588
src/tests/allocator_zookeeper_tests.cpp 72ec292cf5a85d2012d940a347293ef105206ef1
src/tests/balloon_framework_test.sh 7cbd0749011970184158e3bb6c28820d47613327
src/tests/cgroups_tests.cpp 49d835c472f6acf8bff268b0370bedfd13eb555a
src/tests/fault_tolerance_tests.cpp a01d1aef012b636f2ced64d4d2ffabfb6ce42644
src/tests/gc_tests.cpp b61b2de621e227f327ce546b62f8dfc528f3894e
src/tests/master_detector_tests.cpp c0dc301f2a9f8d586864794c0526caac6c68727e
src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3
src/tests/resource_offers_tests.cpp 9f7916873423382443f39c31b1d682dc0e4071bb
src/tests/script.cpp 47fe9d72fd73a3cf73e59b7a0ba4818690e1f130
src/tests/utils.hpp e0036c04bef60d62cc4314a7e0beb02a0071a808
src/tests/zookeeper_test_server.hpp 06320439b993f9612ea01303f7446dadf97dc045
src/tests/zookeeper_tests.cpp 3f001affe0dd4b8002e99a658c47b8ea86ddb7d6
support/atexit.sh PRE-CREATION
support/colors.sh d679da19bd8d7b946d18df1af97f8d6075157d53
Diff: https://reviews.apache.org/r/7720/diff/
Testing
-------
make check
Thanks,
Vinod Kone