[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5878: maven: migrate short-term to reload4j v1.2.18

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #5878:
URL: https://github.com/apache/cloudstack/pull/5878#discussion_r795410367



##########
File path: plugins/integrations/kubernetes-service/pom.xml
##########
@@ -86,9 +86,9 @@
             <version>${cs.guava.version}</version>
         </dependency>
         <dependency>
-            <groupId>log4j</groupId>
-            <artifactId>log4j</artifactId>
-            <version>${cs.log4j.version}</version>

Review comment:
       do we (still) need the version here?

##########
File path: framework/managed-context/pom.xml
##########
@@ -29,9 +29,9 @@
     </parent>
     <dependencies>
         <dependency>
-            <groupId>log4j</groupId>
-            <artifactId>log4j</artifactId>
-            <version>${cs.log4j.version}</version>

Review comment:
       do we (still) need the version here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org